Cinder doesn't work with tox version 1.6

[Jordan Pittier]

Currently in tox.ini, the tox minversion is set to 1.6. But tox 1.6 seems to fail to properly handle the optional requirements. Here's how to reproduce:

cd /tmp/ && virtualenv test-cinder && source test-cinder/bin/activate && pip install tox==1.6

git clone <email address hidden>:openstack/cinder.git && cd cinder

(test-cinder)jordan@jordan-XPS13:/tmp/cinder (master=)$ tox --version
1.6.0 imported from /tmp/test-cinder/local/lib/python2.7/site-packages/tox/__init__.pyc

(test-cinder)jordan@jordan-XPS13:/tmp/cinder (master=)$ tox -e py27
py27 create: /tmp/cinder/.tox/py27
py27 installdeps: -r/tmp/cinder/requirements.txt, -r/tmp/cinder/test-requirements.txt, .[vmdk]
ERROR: invocation failed, logfile: /tmp/cinder/.tox/py27/log/py27-1.log
ERROR: actionid=py27
msg=getenv
[...]
Directory '.[vmdk]' is not installable. File 'setup.py' not found.

ERROR: could not install deps [-r/tmp/cinder/requirements.txt, -r/tmp/cinder/test-requirements.txt, .[vmdk]]
________________________________________________________________________________________________________________ summary _________________________________________________________________________________________________________________
ERROR: py27: could not install deps [-r/tmp/cinder/requirements.txt, -r/tmp/cinder/test-requirements.txt, .[vmdk]]

I believe you need at least Tox 1.7:

(test-cinder)jordan@jordan-XPS13:/tmp/cinder (master=)$ pip install tox==1.7
(test-cinder)jordan@jordan-XPS13:/tmp/cinder (master=)$ tox --version
1.7.0 imported from /tmp/test-cinder/local/lib/python2.7/site-packages/tox/__init__.pyc

(test-cinder)jordan@jordan-XPS13:/tmp/cinder (master=)$ tox -e py27
py27 create: /tmp/cinder/.tox/py27
py27 installdeps: -r/tmp/cinder/requirements.txt, -r/tmp/cinder/test-requirements.txt, .[vmdk]
py27 develop-inst: /tmp/cinder
py27 runtests: PYTHONHASHSEED='0'
py27 runtests: commands[0] | ostestr
[..]
SUCCESS

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/214340

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/214340
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6da01c1b4102b36314b96ad73ec38a3fdec1355b
Submitter: Jenkins
Branch: master

commit 6da01c1b4102b36314b96ad73ec38a3fdec1355b
Author: Eric Harney <email address hidden>
Date: Tue Aug 18 16:22:01 2015 -0400

    Revert "mark oslo.vmware as optional dependency"

    This reverts commit e67adc385ce6997249fbf70e9402264f758fc6f4.

    Adding optional dependency tracking would be nice,
    but Cinder is not yet in a place to do this.

    - Cinder supports tox 1.6 (minversion in tox.ini)
    - This functionality does not work on 1.6, requires 1.7. Tox
      fails to build a test environment if using tox 1.6.
    - We have decided we can't move to tox 1.7 for now.
      ( https://review.openstack.org/#/c/211614/ )

    This reverts commit 478e8e970e54aaf3a034dc6347605c1b18291d0d.
    - Need to remove oslo.vmware from test-requirements.txt now, as
    well.

    Closes-Bug: #1484035

    Change-Id: Icff52508ff1cd67e8c17964c840d3a5cdcfbbce3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/214500

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jordan Pittier (<email address hidden>) on branch: master
Review: https://review.openstack.org/211614
Reason: It's dead jim