top part of the embedded terminal window issue

[almeida]

thank you so much

nautilus-terminal is a great Nauilus Extension which save my life

after update because bug #917424
top part of the embedded terminal window was eaten a little bit

i did a patch below, at least works well for me (fedora 20 with gnome 3)

patch file for /usr/share/nautilus-python/extensions/nautilus_terminal.py

--patch a start---
--- a/nautilus_terminal.py
+++ b/nautilus_terminal.py
@@ -305,7 +305,7 @@ class NautilusTerminal(object):
             height -- The new height (in lines).
         """
         self.swin.set_size_request(-1,
- height * self.term.get_char_height() + 2)
+ height * self.term.get_char_height())

     def _on_term_popup_menu(self, widget, event=None):
         """Displays the contextual menu on right-click and menu-key."""
--patch end---

BTW

if anyone dont like
the missing right part of the frame (really not pretty) too,
do another patch below

--patch b start---
--- a/nautilus_terminal.py
+++ b/nautilus_terminal.py
@@ -166,6 +166,7 @@ class NautilusTerminal(object):
         self.term.connect("drag_data_received", self._on_drag_data_received)
         #Swin
         self.swin = Gtk.ScrolledWindow()
+ self.swin.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.ALWAYS)
         self.swin.nt = self
         #Popup Menu
         self.menu = Gtk.Menu()
--patch end---

updated 3 times seems editor break spaces,
guys move to next comment to get patch files.

[Fabien LOISON (flozz)]

Thank you for the patches, I will test that this afternoon and apply them if no issue

[almeida (sudo-xiangqian)]

my patches never hit the real point of dynamic height

its only let Nautilus show the entire terminal zone when boot with char_height set to 5,
useless for other values and will eaten top part also if resize the Nautilus window later

no ideas about Gtk Window's Coordinate System

good luck

P.S

how about patch Nautilus itself ?
thus trigger Nautilus' navigation from terminal's `cd`

[Fabien LOISON (flozz)]

Hum ok, so I will not have time to check that doday...

> how about patch Nautilus itself ?
> thus trigger Nautilus' navigation from terminal's `cd`

You can try to patch Nautilus but that's out of this extension's scope