public.first_agg needs test

Bug #1483506 reported by Liam Whalen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

Test Writing Day - 2015/08/14

public.first_agg is a potential target for tests.

Liam Whalen (whalen-ld)
tags: added: test-writing-day-0
Yamil (ysuarez)
Changed in evergreen:
assignee: nobody → Yamil (ysuarez)
Revision history for this message
Yamil (ysuarez) wrote :

I also did a test for public.first which relies on public.first_agg.

Here is my working branch...

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ysuarez/lp1483506_public.first_agg_pgtap

tags: added: pullrequest
Revision history for this message
Yamil (ysuarez) wrote :

I added a pull request, but I think I should first get a sign-off?

Changed in evergreen:
assignee: Yamil (ysuarez) → nobody
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

working/user/stompro/lp1483506_public.first_agg_pgtap-signoff
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1483506_public.first_agg_pgtap-signoff

Tested on a 8/22/2015 version of Master, all the tests passed, looks good.
Josh

postgres@virt-egtestapp4:/home/opensrf/Evergreen/Open-ILS/src/sql/Pg/t$ pg_prove -d evergreen -v public.first_agg.pg public.first.pg
public.first_agg.pg ..
1..2
ok 1 - testing having two interger parameters; picking first parameter
ok 2 - testing having two string parameters; picking first parameter
ok
public.first.pg ......
1..2
ok 1 - testing having three rows; picking first row
ok 2 - testing having one row; picking first row
ok
All tests successful.
Files=2, Tests=4, 0 wallclock secs ( 0.07 usr 0.01 sys + 0.17 cusr 0.04 csys = 0.29 CPU)
Result: PASS

tags: added: signedoff
Revision history for this message
Kathy Lussier (klussier) wrote :

Thank you Yamil and Josh!

Merged to master.

Changed in evergreen:
status: New → Fix Committed
milestone: none → 2.next
Liam Whalen (whalen-ld)
tags: removed: test-writing-day-0
Changed in evergreen:
milestone: 2.next → 2.10-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.