Cliff does not allow override of some arguments

Bug #1483378 reported by Terry Howe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cliff
Invalid
Undecided
Terry Howe
python-openstackclient
Fix Released
Medium
Terry Howe

Bug Description

argparse does not have a way to get and modify arguments set by a parent class, so it would be convenient if cliff allowed arguments to be override for the default value and perhaps the help text. OSC for instance uses a slightly different usage of --debug where it sets verbose_level=3 if --debug. The help text for --debug does not say that.

Also, the default value for --debug is False and this makes it so OCC cannot override the value. If it was set to None, OCC would set it out of the file.

Terry Howe (thowe-g)
Changed in python-cliff:
assignee: nobody → Terry Howe (thowe-g)
Changed in python-openstackclient:
assignee: nobody → Terry Howe (thowe-g)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cliff (master)

Fix proposed to branch: master
Review: https://review.openstack.org/214262

Changed in python-cliff:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstackclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/214264

Changed in python-openstackclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/214264
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=00eebaf5bc5ff7a383a8ed085098abc24c8a2e74
Submitter: Jenkins
Branch: master

commit 00eebaf5bc5ff7a383a8ed085098abc24c8a2e74
Author: TerryHowe <email address hidden>
Date: Tue Aug 18 10:09:46 2015 -0600

    Override the debug default and help text

    Cliff sets the default debug value to False and this makes it
    impossible to override debug with OCC. If we set the default to
    None, we can override debug in clouds.yaml. Also, OSC changes
    the meaning of --debug, so modify the help text.

    Change-Id: I5e6680b2286cd7f55afe4b083fae5f8a4a9567a2
    Closes-Bug: #1483378

Changed in python-openstackclient:
status: In Progress → Fix Committed
Changed in python-openstackclient:
importance: Undecided → Medium
Dean Troyer (dtroyer)
Changed in python-openstackclient:
milestone: none → 1.7.1
Revision history for this message
Steve Martinelli (stevemar) wrote :

this has been released

Changed in python-openstackclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cliff (master)

Change abandoned by Terry Howe (<email address hidden>) on branch: master
Review: https://review.openstack.org/214262

Terry Howe (thowe-g)
Changed in python-cliff:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-openstackclient 1.7.2

This issue was fixed in the openstack/python-openstackclient 1.7.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.