Mir

android-input-static is linked into both mirclient and mirserver

Bug #1483223 reported by Alan Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Alan Griffiths
mir (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

There's a "helpful comment" in src/client/input/CMakeLists.txt:

    # As we put android-input-static in MIR_CLIENT_REFERENCES it ends up linked into
    # libmirserver. But linking into libmircommon fails as it in turn needs
    # mir::mir::terminate_with_current_exception() from mirserver
    list(APPEND MIR_CLIENT_REFERENCES android-input-static)

This means we have a static library that (potentially) everything that links against mirclient tries to link to.

At the very least this risks breaking the ODR

Tags: bloat

Related branches

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

In addition to the noted dependency on mir::terminate_with_current_exception(), there's also a dependency on mir::udev::Context from mirplatform.

Changed in mir:
assignee: nobody → Alan Griffiths (alan-griffiths)
tags: added: bloat
Changed in mir:
importance: Undecided → Medium
Changed in mir:
milestone: none → 0.16.0
status: New → In Progress
Changed in mir:
milestone: 0.16.0 → 0.17.0
Changed in mir:
status: In Progress → Fix Committed
milestone: 0.17.0 → none
Changed in mir:
milestone: none → 0.16.0
no longer affects: mir/0.16
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

mir (0.16.0+15.10.20150921.1-0ubuntu1) wily; urgency=medium

Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.