android-input-static is linked into both mirclient and mirserver
Bug #1483223 reported by
Alan Griffiths
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Alan Griffiths | ||
| mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
There's a "helpful comment" in src/client/
# As we put android-
# libmirserver. But linking into libmircommon fails as it in turn needs
# mir::mir:
list(APPEND MIR_CLIENT_
This means we have a static library that (potentially) everything that links against mirclient tries to link to.
At the very least this risks breaking the ODR
Related branches
lp:~alan-griffiths/mir/conquer-android-input-static
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Daniel van Vugt: Abstain
- Kevin DuBois (community): Approve
- Cemil Azizoglu (community): Approve
-
Diff: 359 lines (+138/-63)13 files modified3rd_party/android-input/android/CMakeLists.txt (+20/-18)
3rd_party/android-input/android/frameworks/base/services/input/EventHub.cpp (+0/-34)
3rd_party/android-input/android/frameworks/base/services/input/InputReader.cpp (+33/-0)
benchmarks/android-input/CMakeLists.txt (+0/-2)
src/client/input/CMakeLists.txt (+0/-5)
src/common/CMakeLists.txt (+1/-0)
src/common/symbols.map (+54/-0)
src/platform/CMakeLists.txt (+1/-0)
src/platform/symbols.map (+28/-0)
src/server/CMakeLists.txt (+0/-1)
src/utils/CMakeLists.txt (+1/-1)
tests/integration-tests/CMakeLists.txt (+0/-1)
tests/unit-tests/CMakeLists.txt (+0/-1)
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | #1 |
| Changed in mir: | |
| assignee: | nobody → Alan Griffiths (alan-griffiths) |
| tags: | added: bloat |
| Changed in mir: | |
| importance: | Undecided → Medium |
| Changed in mir: | |
| milestone: | none → 0.16.0 |
| status: | New → In Progress |
| Changed in mir: | |
| milestone: | 0.16.0 → 0.17.0 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| milestone: | 0.17.0 → none |
| Changed in mir: | |
| milestone: | none → 0.16.0 |
| no longer affects: | mir/0.16 |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #2 |
| Changed in mir (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | New → Fix Released |
To post a comment you must log in.
In addition to the noted dependency on mir::terminate_