PBR

pbr alters sdist output for non-pbr-using projects

Bug #1483067 reported by Robert Collins
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
PBR
Fix Released
Critical
Sachi King

Bug Description

pip$ python setup.py sdist
running sdist
running egg_info
writing pbr to pip.egg-info/pbr.json

This only happens in git trees AFAICT.

Marking critical since this is a fairly huge nono.

Revision history for this message
Robert Collins (lifeless) wrote :

the bug is that pbr should only be active, and only change things, for setup's where setup(pbr=True).

Sachi King (nakato)
Changed in pbr:
assignee: nobody → Sachi King (nakato)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to pbr (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217528

Changed in pbr:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to pbr (master)

Reviewed: https://review.openstack.org/217528
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=8047f2feafeead5f4913f9ab1d7d2c6d0ccf79e0
Submitter: Jenkins
Branch: master

commit 8047f2feafeead5f4913f9ab1d7d2c6d0ccf79e0
Author: Sachi King <email address hidden>
Date: Thu Aug 27 15:52:03 2015 +1000

    Have pbr egg_info.writer check PBR is enabled

    PBR is currently creating a pbr.json for any install originating from a
    git tree as pbr_json is an entry point for egg_info.writers. If pbr is
    not set to True in setup() we now exit before doing any work.

    Change-Id: Ia37e37c22c2396f6a10aa2075ea8c501e571fee3
    Closes-Bug: 1483067

Changed in pbr:
status: In Progress → Fix Committed
Changed in pbr:
milestone: none → 1.7.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.