do not list openstackclient as a requirement

Bug #1482925 reported by Steve Martinelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
Fix Released
Low
Asha

Bug Description

python-openstackclient is listed as a requirement (https://github.com/openstack/python-manilaclient/blob/master/requirements.txt#L21). But AFACT, the OSC plugin (https://github.com/openstack/python-manilaclient/blob/bd28eda9d21eab043ac85c78f620f131f4b156b4/manilaclient/client.py#L20) is incomplete as there are no entry_points listed in setup.cfg (https://github.com/openstack/python-manilaclient/blob/master/setup.cfg).

It seems like it was mostly lifted for use in functional tests: https://github.com/openstack/python-manilaclient/blob/0a4ccec3f5357a5ef0526553d8eaced31691f8d4/manilaclient/tests/functional/client.py#L158-L161

It seems like manilaclient is still using the old nova/argparse method (https://github.com/openstack/python-manilaclient/blob/0a4ccec3f5357a5ef0526553d8eaced31691f8d4/manilaclient/shell.py#L106-L114) - not sure if you all plan on moving to an openstackclient plugin, but you might want to put openstackclient in test-requirements.txt if it's not going to be used.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/211844

Changed in python-manilaclient:
assignee: nobody → Asha (assarava)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/211844
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=fec43dd54d6f31d709c9da114b309ef8606a007b
Submitter: Jenkins
Branch: master

commit fec43dd54d6f31d709c9da114b309ef8606a007b
Author: Asha Saravanamohan <email address hidden>
Date: Wed Aug 12 00:00:20 2015 -0400

    Move requirement Openstack client to test-requirements

    Closes-Bug: #1482925

    Change-Id: Icb1cae0a24fd49c482c627ae4d5d228e53cee373
    Signed-off-by: Asha Saravanamohan <email address hidden>

Changed in python-manilaclient:
status: In Progress → Fix Committed
Changed in python-manilaclient:
importance: Undecided → Low
Changed in python-manilaclient:
milestone: none → 1.3.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.