launch vm can not choose flavor

Bug #1482507 reported by Sun Jing
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Raga lahari

Bug Description

when launch instance "instance boot source " choose "Boot from image",
then "Flavor" will show tips: "Some flavors not meeting minimum image requirements have been disabled."
and some flavor can not be choosed.

then "instance boot source " choose "Boot from volume",the disabled flavors
also can not be choosed.

Infact the disabled flavor should turn to be enabled.

Changed in horizon:
assignee: nobody → Raga lahari (raga-lahari)
Sun Jing (sun-jing22)
summary: - launch vm can choose flavor
+ launch vm can not choose flavor
Revision history for this message
Raga lahari (raga-lahari) wrote :

Hi,

Proposing following change in /opt/stack/horizon/static/horizon/js/horizon.instances.js to fix this bug.

// Handle field toggles for the Launch Instance source type field
  function update_launch_source_displayed_fields (field) {
   ...
   ...
   $this.closest(".form-group").nextAll().hide();
   +if (base_type != "image_id" ) {
   + horizon.Quota.resetFlavors();
   +}
   +else {
   + horizon.Quota.disableFlavorsForImage();
   +}
   switch(base_type) {
    ...
    ...
As static folder is under .gitignore, Can some one from horizon development team help us to commit this file.

Revision history for this message
Matthias Runge (mrunge) wrote :

check out horizon from github, the file to change is
horizon/static/horizon/js/horizon.instances.js (within your checkout)

that is not static/horizon/js.....

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221758

Changed in horizon:
status: New → In Progress
Changed in horizon:
importance: Undecided → Medium
milestone: none → ongoing
Changed in horizon:
milestone: ongoing → next
tags: added: newton-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/221758
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b1373e0438c19485f3b0223e93948b5d4519c7ae
Submitter: Jenkins
Branch: master

commit b1373e0438c19485f3b0223e93948b5d4519c7ae
Author: Ragalahari <email address hidden>
Date: Wed Sep 9 19:08:42 2015 +0530

    Reset flavors for other than "Boot from Image" source type.

    If a launched instance from "Boot from image" source type is not
    meeting the given image RAM/disk requirements, the "Flavor" field
    of Launch Instance will display the below message.

    "Some flavors not meeting minimum image requirements have been
    disabled."

    And the flavors that are not meeting the specified requirements
    will be disabled under "Flavor" field.

    After this message has been shown if we try to choose a source
    type other than "Boot from image", the flavors are still in
    disabled mode and message also not being cleared.

    To fix this issue, Set the image name to default when the source type
    is changed from "Boot from image" to other source type.So that
    disableFlavorsForImage() has been called on Image name change to
    reset flavors.

    Change-Id: I1a105eb84bd5d92ad521d9a8ae290912d48cf275
    Closes-Bug: #1482507

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → ocata-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/408487

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/408487
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2c54748d0f0c7911c09f5fc50354de7cd3dc650b
Submitter: Jenkins
Branch: stable/newton

commit 2c54748d0f0c7911c09f5fc50354de7cd3dc650b
Author: Ragalahari <email address hidden>
Date: Wed Sep 9 19:08:42 2015 +0530

    Reset flavors for other than "Boot from Image" source type.

    If a launched instance from "Boot from image" source type is not
    meeting the given image RAM/disk requirements, the "Flavor" field
    of Launch Instance will display the below message.

    "Some flavors not meeting minimum image requirements have been
    disabled."

    And the flavors that are not meeting the specified requirements
    will be disabled under "Flavor" field.

    After this message has been shown if we try to choose a source
    type other than "Boot from image", the flavors are still in
    disabled mode and message also not being cleared.

    To fix this issue, Set the image name to default when the source type
    is changed from "Boot from image" to other source type.So that
    disableFlavorsForImage() has been called on Image name change to
    reset flavors.

    Change-Id: I1a105eb84bd5d92ad521d9a8ae290912d48cf275
    Closes-Bug: #1482507
    (cherry picked from commit b1373e0438c19485f3b0223e93948b5d4519c7ae)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b2

This issue was fixed in the openstack/horizon 11.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.2

This issue was fixed in the openstack/horizon 10.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.