Boolean kwargs not handled properly in L3 routing tests

[Bob Melander]

The unit test suite for L3 routing includes a mixin class that provides a function_create_router(...) to create a Neutron router.

This function takes kwargs to allow arbitrary arguments to be passed in the create router REST API call. The code contains a test to ensure that the provided kwarg indeed contains a value. However, the way that test is written makes it incompatible with Boolean kwargs. As a result, if a Boolean kwarg is provided it will, incorrectly, be ignored.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/209803

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/209803
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e28aa9761751d7fa12dba1c35076c3c975b7cd3f
Submitter: Jenkins
Branch: master

commit e28aa9761751d7fa12dba1c35076c3c975b7cd3f
Author: Bob Melander <email address hidden>
Date: Sat Jun 27 19:14:19 2015 +0200

    Make '_create_router' function handle Boolean kwargs correctly

    The function allows arbitrary kw arguments to be specificed.
    Those kw arguments whose key is specified in the function
    parameter 'arg_list' are then passed in the create router REST
    API call.

    The code line that checks if a kw argument key is included in
    'arg_list' does not work with Boolean kw arguments. Nor does it
    work with None kw argument values. This is a limitation as
    tests in inheriting classes may need such kw arguments.

    This patch fixes the faulty 'if' clause so that it simply
    checks that the kw argument key is in 'arg_list'. This makes it
    support Boolean kw arguments and kw arguments with value None.

    Closes-Bug: #1482108
    Change-Id: I5618dc4d5c803c7614dd1f579db3c79928007fb6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/211492

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/211492
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a7b91632fc65ab9d2687298c68b1d715866d0356
Submitter: Jenkins
Branch: feature/pecan

commit 966203f89dee8fe61fb2dce654e36e510e80380f
Author: Sukhdev Kapur <email address hidden>
Date: Wed Jul 1 16:30:44 2015 -0700

    Neutron-Ironic integration patch

    This patch is in preparation for the integration
    of Ironic and Neutron. A new vnic_type is being
    added so that ML2 drivers can filter for all
    Ironic ports based upon match for 'baremetal'.
    Nova/Ironic will set this vnic_type when issuing
    port-create request to neutron.
    (e.g. binding:vnic_type = 'baremetal' )

    Change-Id: I25dc9472b31db052719db503a10c1fb1a55572ef
    Partial-Implements: blueprint neutron-ironic-integration

commit 236e408272bcb9b8e957524864e571b5afdc4623
Author: Oleg Bondarev <email address hidden>
Date: Tue Jul 7 12:02:58 2015 +0300

    DVR: fix router scheduling

    Fix scheduling of DVR routers to not stop scheduling once
    csnat portion was scheduled. See bug report for failing
    scenario.

    This partially reverts
    commit 3794b4a83e68041e24b715135f0ccf09a5631178
    and fixes bug 1374473 by moving csnat scheduling
    after general dvr router scheduling, so double binding does
    not happen.

    Closes-Bug: #1472163
    Related-Bug: #1374473
    Change-Id: I57c06e2be732e47b6cce7c724f6b255ea2d8fa32

commit e152f93878b9bb6af7cfedc9e045892fcf7d0615
Author: Assaf Muller <email address hidden>
Date: Sat Aug 8 21:15:03 2015 +0300

    TESTING.rst love

    Change-Id: I64b569048f8f87ea2fe63d861302b4020d36493d

commit 633c52cca1b383af2c900e1663c8682114acd177
Author: sridhargaddam <email address hidden>
Date: Wed Aug 5 10:49:33 2015 +0000

    Avoid dhcp_release for ipv6 addresses

    dhcp_release is only supported for IPv4 addresses [1] and not for
    IPv6 addresses [2]. There will be no effect when it is called with
    IPv6 address. This patch adds a corresponding note and avoids calling
    dhcp_release for IPv6 addresses.

    [1] http://manpages.ubuntu.com/manpages/trusty/man1/dhcp_release.1.html
    [2] http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2013q2/007084.html

    Change-Id: I8b8316c9d3d011c2a687a3a1e2a4da5cf1b5d604

commit 2de8fad17402f38bbc30204ee2f4f99cf21cb69d
Author: OpenStack Proposal Bot <email address hidden>
Date: Mon Aug 10 06:11:06 2015 +0000

    Imported Translations from Transifex

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I2b423e83a7d0ac8b23239f81fe33dd8382c6fff6

commit fef79dc7b9162e03c8891645494c115b52d4d014
Author: Henry Gessau <email address hidden>
Date: Mon Aug 3 23:30:34 2015 -0400

    Consistent layout and headings for devref

    The lack of convention for heading levels among the independently
    written devref documents was starting to make the Table of Contents
    look rather messy when rendered in HTML.

    This patch does not cover the "Neutron Internals" section since its
    layo...