Orders post returns misleading error message

[Pradeep Kumar Singh]

curl -X POST http://localhost:9311/v1/orders/ -H 'X-Auth-Token:e0c5397774db42308c1f1a39290a41bd' -H 'content-type:application/json' -d '{"type":"key", "meta":{"algorithm": "AES"}}'
{"code": 400, "description": "Provided field value is not supported", "title": "Bad Request"}

bit_length is a required field in meta. So, this command should fail, but the returned message is misleading.

It should say "required field missing", not "provided field value not supported".

[Dave McCowan (dave-mccowan)]

bit_length is a required field in meta. So, this command should fail, but the returned message is wrong.
It should say "required field missing", not "providing field value no supported".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235115

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235115
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=96edecca111b29740cabc6d00a6563806fa1bc7d
Submitter: Jenkins
Branch: master

commit 96edecca111b29740cabc6d00a6563806fa1bc7d
Author: Pradeep Kumar Singh <email address hidden>
Date: Thu Oct 15 12:22:40 2015 +0530

    Correct the returned message when bit_length is absent

    bit_length is a required field in meta. So order creation
    should fail when bit_length is missing.This fix corrects
    the returned message.
    Before_fix:
    stack@devstack:~$ curl -X POST http://localhost:9311/v1/orders/ -H
    'X-Auth-Token:5c5b375d974d4391afb51c63b2ffa6dc'
    -H 'content-type:application/json'
    -d '{"type":"key", "meta":{"algorithm": "AES"}}';echo
    {"code": 400, "description": "Provided field value is not supported",
    "title": "Bad Request"}
    After_fix:
    stack@devstack:~$ curl -X POST http://localhost:9311/v1/orders/ -H
    'X-Auth-Token:5c5b375d974d4391afb51c63b2ffa6dc'
    -H 'content-type:application/json'
    -d '{"type":"key", "meta":{"algorithm": "AES"}}';echo
    {"code": 400, "description": "Provided object does not match schema
     'Order': 'bit_length' is required field for key type order.
    Invalid property: 'meta'", "title": "Bad Request"}
    Closes-Bug: #1482009

    Change-Id: Id8c67d00d19768e7479a2e548436dc9e71f0e5cc

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/barbican 2.0.0.0b1 development milestone.