Hot-plugging can fail at boot time

[Ryan Petrello]

The CheckBoot state has a code path which transitions to ReplugVM, but the CheckBoot state doesn't handle ReplugVM properly. This results in a scenario where the rug endlessly loops over CheckBoot for a specific router:

https://github.com/stackforge/akanda-rug/blob/942e3377773dbc3781ae95c14d58a9917d52fafa/akanda/rug/state.py#L249
https://github.com/stackforge/akanda-rug/blob/942e3377773dbc3781ae95c14d58a9917d52fafa/akanda/rug/instance_manager.py#L236
https://github.com/stackforge/akanda-rug/blob/942e3377773dbc3781ae95c14d58a9917d52fafa/akanda/rug/instance_manager.py#L341

This can be reproduced by:

1. Disable the rug for a router
2. `akanda-debug-router --config-file /etc/akanda-rug/rug.ini --router-id <router-id>` to boot a new router VM
3. *Before* akanda-rug is able to confirm the router VM's availability, remove an interface from the router (e.g., via nova interface-detach) so that the interfaces don't match on the initial config test.
4. `akanda-debug-router --config-file /etc/akanda-rug/rug.ini --router-id <router-id>` again to see the failure where the state machine goes from CheckBoot -> CheckBoot (even though the router is ready for hot plug + configuration)

[Ryan Petrello (ryan-petrello)]

https://bugs.launchpad.net/akanda/+bug/1481702

[Ryan Petrello (ryan-petrello)]

https://github.com/dreamhost/akanda-rug/pull/24

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/209464
Committed: https://git.openstack.org/cgit/stackforge/akanda-rug/commit/?id=918b5ed375ea00d01f4595fcba8757bfdc2f4b3d
Submitter: Jenkins
Branch: master

commit 918b5ed375ea00d01f4595fcba8757bfdc2f4b3d
Author: Ryan Petrello <email address hidden>
Date: Wed Aug 5 07:08:10 2015 -0400

    Properly transition from CheckBoot -> ReplugVM.

    Fixes-bug: #1481702
    Change-Id: I041e404456c183deba0fcab7aaf7c28a9801baa8