Neutron usage_audit's router and floating IP reporting doesn't work with ML2 plugin

Bug #1481692 reported by Toni Ylenius
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Toni Ylenius
Juno
Fix Released
Undecided
Unassigned

Bug Description

Neutron usage_audit's router and floating IP reporting doesn't work with ML2 plugin as router functionality has been moved to L3 plugin.

The bug has been noted earlier
http://lists.openstack.org/pipermail/openstack/2014-September/009371.html
but I couldn't find a bug report from launchpad.

The error in neutron-usage-audit.log looks like this
2015-08-05 12:00:04.295 30126 CRITICAL neutron [req-74df5d30-7070-4152-86d3-cc4e2ef4fefa None] 'Ml2Plugin' object has no attribute 'get_routers'
2015-08-05 12:00:04.295 30126 TRACE neutron Traceback (most recent call last):
2015-08-05 12:00:04.295 30126 TRACE neutron File "/usr/bin/neutron-usage-audit", line 10, in <module>
2015-08-05 12:00:04.295 30126 TRACE neutron sys.exit(main())
2015-08-05 12:00:04.295 30126 TRACE neutron File "/usr/lib/python2.6/site-packages/neutron/cmd/usage_audit.py", line 55, in main
2015-08-05 12:00:04.295 30126 TRACE neutron for router in plugin.get_routers(cxt):
2015-08-05 12:00:04.295 30126 TRACE neutron AttributeError: 'Ml2Plugin' object has no attribute 'get_routers'
2015-08-05 12:00:04.295 30126 TRACE neutron

I found the bug on icehouse but the relevant code is same in HEAD. My plan is to submit a patch to fix the bug, the fix is quite trivial.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209488

Changed in neutron:
assignee: nobody → Toni Ylenius (toni-ylenius)
status: New → In Progress
Changed in neutron:
milestone: none → mitaka-1
importance: Undecided → Medium
tags: added: kilo-backport-potential
tags: added: juno-backport-potential
tags: added: liberty-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/209488
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2bded62d6a6a141e610a06e5f40bb28c0b26da5c
Submitter: Jenkins
Branch: master

commit 2bded62d6a6a141e610a06e5f40bb28c0b26da5c
Author: Toni Ylenius <email address hidden>
Date: Wed Aug 5 15:06:00 2015 +0300

    usage_audit: Fix usage_audit to work with ML2

    The script didn't work with the ML2 plugin as router related
    functionality is moved to the L3 router service plugin. The fix assumes
    that the L3 router service plugin is in use, and this seems to apply to
    most of the current core plugins.

    Change-Id: If3eb7bde4a5b8b9ca2ac0bd7327325f6c0ad620a
    Closes-Bug: 1481692

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
no longer affects: neutron/liberty
Changed in neutron:
milestone: mitaka-1 → liberty-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/230521
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dd197db312f4bc5a2a661c86125b06d71c45e742
Submitter: Jenkins
Branch: stable/liberty

commit dd197db312f4bc5a2a661c86125b06d71c45e742
Author: Toni Ylenius <email address hidden>
Date: Wed Aug 5 15:06:00 2015 +0300

    usage_audit: Fix usage_audit to work with ML2

    The script didn't work with the ML2 plugin as router related
    functionality is moved to the L3 router service plugin. The fix assumes
    that the L3 router service plugin is in use, and this seems to apply to
    most of the current core plugins.

    Change-Id: If3eb7bde4a5b8b9ca2ac0bd7327325f6c0ad620a
    Closes-Bug: 1481692
    (cherry picked from commit 2bded62d6a6a141e610a06e5f40bb28c0b26da5c)

tags: added: in-stable-liberty
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/233107

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/233108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/juno)

Reviewed: https://review.openstack.org/233108
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c9fb19244f67f4014e436063cbb8c68026f268f3
Submitter: Jenkins
Branch: stable/juno

commit c9fb19244f67f4014e436063cbb8c68026f268f3
Author: Toni Ylenius <email address hidden>
Date: Wed Aug 5 15:06:00 2015 +0300

    usage_audit: Fix usage_audit to work with ML2

    The script didn't work with the ML2 plugin as router related
    functionality is moved to the L3 router service plugin. The fix assumes
    that the L3 router service plugin is in use, and this seems to apply to
    most of the current core plugins.

    Change-Id: If3eb7bde4a5b8b9ca2ac0bd7327325f6c0ad620a
    Closes-Bug: 1481692
    (cherry picked from commit 2bded62d6a6a141e610a06e5f40bb28c0b26da5c)

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc2 → 7.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235300

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)
Download full text (16.6 KiB)

Reviewed: https://review.openstack.org/235300
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=140ccc36d172bead2605968b3d61b36cca8a0040
Submitter: Jenkins
Branch: master

commit 6dcfe3a9362ae5fcf18e5cfb59663e43446cd59c
Author: Kevin Benton <email address hidden>
Date: Tue Oct 6 19:28:47 2015 -0700

    Mock oslo policy HTTPCheck instead of urllib

    We were mocking internal behavior of oslo policy by
    patching urllib. This will break with the upcoming oslo
    release that switches to requests.

    This patch changes the mock to the HTTPCheck level and we
    can leave implementation details testing up to oslo_policy.

    Change-Id: I07957f01307e25f1547197c720eea6e3e7f0ef5a
    Closes-Bug: #1503890
    (cherry picked from commit a0f1d9d6de1560be91d3001c8ac9f880a7a5a7e0)

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I7dfbf240333095d91a414ba15a439bdc4804eb25
    (cherry picked from commit 86ad967e40c2c6752ec0fb46cfd3098ede0c7178)

    Fix functional test_server tests

    Now oslo.service 0.10.0 no longer sends SIGHUP to parent and
    children services.

    This was a chance introduced by 286a6ea, and since it invalidated
    the very logic under test, this must be revised.

    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Change-Id: I18a11283925369bc918002477774f196010a1bc3
    Closes-bug: #1505438
    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Make test_server work with older versions of oslo.service

    Change I18a11283925369bc918002477774f196010a1bc3 fixed the test for
    oslo.service >= 0.10.0, but it also broke it for older versions of
    oslo.service. Since the library has minimal version of >= 0.7.0 in
    requirements.txt, test should pass for those versions too.

    Now, instead of validating that either reset() or restart() of workers
    are triggered on SIGHUP, just validate that .start() is triggered the
    expected number of times (either way, no matter how oslo.service decide
    to clean up the children, they exit and then are respawned).

    Change-Id: I41f9d3af780b3178b075bc1e7084f417a2bd1378
    Closes-Bug: #1505645
    (cherry picked from commit 7bb40921660cf29beb68e338e205499efd6ffa36)

    Fixed multiple py34 gate issues

    1. Scope mock of 'open' to module

    By mocking 'open' at the module level, we can avoid affecting
    'open' calls from other modules.

    2. Stop using LOG.exception in contexts with no sys.exc_info set

    Python 3.4 logger fills in record.exc_info with sys.exc_info() result
    [1], and then it uses it to determine the current exception [2] to
    append to the log message. Since there is no exception, exc_info[1] is
    None, and we get AttributeError inside traceback module.

    It's actually a bug in Python interpreter that it attempt to access the
    attribute when there is no exception. It turns out that it's fixed in
    latest master of cPython [3] (...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/233107
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f419a5ec9d24de1d6f9bcdd461fa8f667202bd12
Submitter: Jenkins
Branch: stable/kilo

commit f419a5ec9d24de1d6f9bcdd461fa8f667202bd12
Author: Toni Ylenius <email address hidden>
Date: Wed Aug 5 15:06:00 2015 +0300

    usage_audit: Fix usage_audit to work with ML2

    The script didn't work with the ML2 plugin as router related
    functionality is moved to the L3 router service plugin. The fix assumes
    that the L3 router service plugin is in use, and this seems to apply to
    most of the current core plugins.

    Change-Id: If3eb7bde4a5b8b9ca2ac0bd7327325f6c0ad620a
    Closes-Bug: 1481692
    (cherry picked from commit 2bded62d6a6a141e610a06e5f40bb28c0b26da5c)

tags: added: in-stable-kilo
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b1

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.