Resource object refresh is invalid

Bug #1481644 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Thomas Herve

Bug Description

It passes the result of get_object_object to the resource_db parameter to from_object. But this one actually expects a raw database object, not an already wrapped resource object.

This causes issues with properties encryption.

Thomas Herve (therve)
Changed in heat:
assignee: nobody → Thomas Herve (therve)
importance: Undecided → High
milestone: none → liberty-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209401

Changed in heat:
status: New → In Progress
Thomas Herve (therve)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/209401
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=f3101bf9e4f2400e0225c7d3e6f64e6771841a03
Submitter: Jenkins
Branch: master

commit f3101bf9e4f2400e0225c7d3e6f64e6771841a03
Author: Thomas Herve <email address hidden>
Date: Wed Aug 5 10:33:38 2015 +0200

    Fixes Resource object refresh to use db object

    Fix Resource object _refresh method to actually pass a database object
    to _from_db_object, instead of wrapped one. This fixes properties
    encryption.

    Change-Id: I3d8d54fa7441c95fc3de5354f80ce2e7e2ba7054
    Closes-Bug: #1481644

Changed in heat:
status: In Progress → Fix Committed
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-3 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.