launch instance not respecting picked project

[YaZug]

Description of problem:

If you have a user with more than one project and admin role on one of the projects you get an additional pane when launching an instance. If you pick a project to launch under that isn't the current active project and try to launch a new instance the instance is launched under the current project not the selected project.

How reproducible: Every time

Steps to Reproduce:
1. Have a user with 2 projects and an admin role on one of the projects
2. log in as that user
3. identity -> projects -> set as active (project with admin role)
4. project -> instances -> Launch Instance -> Projects & Users -> Select non active project
5. Launch Instance (simple instance is fine)

Actual results:
Instance launched within current project

Expected results:
Instance launched within requested project

2015.1.0

[YaZug (jon-schlueter)]

after doing some more digging through the code it would appear this panel was hidden back in 2012 so that it wouldn't actually be visible but somewhere since it's accessible again if you have the admin role.

https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#L70

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220436

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/220436
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[YaZug (jon-schlueter)]

From reading comments in code review I'm wondering if I found a hole in the UI that allows what should have been a disabled feature?

[Matthias Runge (mrunge)]

I assume you were hit by a cached novaclient object, which had still a token scoped to the other project. That is hard to reproduce and harder to verify, the fix really fixes the issue.

[Jason E. Rist (jason-rist)]

Is this bug still being looked at?

[Gary W. Smith (gary-w-smith)]

The launch instance page was reimplemented several releases ago, and there is no option for an admin to choose a different project other than the one that the session is currently scoped to.