pbr 1.4 fails to install oslo.config from sdist when git is not installed

[Robert Collins]

Looks like the patch I added to generate AUTHORS/ChangeLog from source needs to cater for the sdist case better. We handle git installed but in an sdist tree. We don't handle git not installed.

[toralf (toralf-foerster)]

>>> Source compiled.
>>> Test phase [not enabled]: dev-python/pbr-1.4.0

>>> Install pbr-1.4.0 into /var/tmp/portage/dev-python/pbr-1.4.0/image/ category dev-python
 * python3_4: running distutils-r1_run_phase distutils-r1_python_install
/usr/bin/python3.4 setup.py install --root=/var/tmp/portage/dev-python/pbr-1.4.0/image//_python3.4
running install
/usr/lib64/python3.4/site-packages/nose/plugins/manager.py:395: RuntimeWarning: Unable to load plugin html-output = htmloutput.htmloutput:HtmlOutput: No module named 'version'
  RuntimeWarning)
error: [Errno 2] No such file or directory: 'git'
 * ERROR: dev-python/pbr-1.4.0::gentoo failed (install phase):

  -----------------------------------------------------------------

  This is an unstable amd64 chroot image (named amd64-desktop-unstable_20150802-115040) at a hardened host acting as a tinderbox.

Portage 2.2.20 (python 3.4.3-final-0, default/linux/amd64/13.0/desktop, gcc-4.9.3, glibc-2.21-r1, 4.0.8-hardened x86_64)
=================================================================
System uname: Linux-4.0.8-hardened-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem: 16164692 total, 1073584 free
KiB Swap: 0 total, 0 free

[P7cvv6k (p7cvv6k)]

+ 08 Aug 2015; Patrick Lauer <email address hidden> pbr-1.4.0.ebuild:
+ Remove keywords for uninstallable version #557008

Sigh.

[Mike Gilbert (floppym)]

Adding dev-vcs/git to DEPEND would "fix" this, though it isn't a great solution.

I *think* the problem was introduced here:

http://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=89402a71776a02c69b67fc14452b82a9a9d85ac0

[Matthew Thode (prometheanfire)]

we think it was caused by this.

http://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=89402a71776a02c69b67fc14452b82a9a9d85ac0

[Matthew Thode (prometheanfire)]

not checking if git was installed before calling git

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/210964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/210964
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=5c0bb9186fe2d65901744b00af24c8c50b3e1d29
Submitter: Jenkins
Branch: master

commit 5c0bb9186fe2d65901744b00af24c8c50b3e1d29
Author: Robert Collins <email address hidden>
Date: Mon Aug 10 16:22:26 2015 +1200

    Handle git being entirely absent

    When we try to find the git directory, if git is not present, treat
    that the same as an error from git itself. Sadly tests for this are
    nearly impossible to meaningfully write, since we always have git
    installed. I can do a mock based test if folk want one.

    Change-Id: If6160d1fb3def8133bdd0b66105e60ef93f80f82
    Closes-Bug: #1481468

[Matthew Thode (prometheanfire)]

You mind trying this patch real quick?

https://git.openstack.org/cgit/openstack-dev/pbr/patch/?id=5c0bb9186fe2d65901744b00af24c8c50b3e1d29

[Matthew Thode (prometheanfire)]

backported and tested patch, readded keywords, etc etc