btn-launch incorrectly declared for launch instance NG
Bug #1481135 reported by
Richard Jones
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Undecided
|
Richard Jones |
Bug Description
The code declaring the launch instance NG buttons currently has the classes attribute as:
classes = ("btn-launch")
this should be a sequence of strings, not a single string.
Changed in horizon: | |
assignee: | nobody → Richard Jones (r1chardj0n3s) |
status: | New → In Progress |
Changed in horizon: | |
assignee: | Richard Jones (r1chardj0n3s) → Shaoquan Chen (sean-chen2) |
Changed in horizon: | |
assignee: | Shaoquan Chen (sean-chen2) → Richard Jones (r1chardj0n3s) |
Changed in horizon: | |
milestone: | none → liberty-3 |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | liberty-3 → 8.0.0 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/208316 /git.openstack. org/cgit/ openstack/ horizon/ commit/ ?id=9d3823b3d83 b7ac4206898ba72 bc300529d690f3
Committed: https:/
Submitter: Jenkins
Branch: master
commit 9d3823b3d83b7ac 4206898ba72bc30 0529d690f3
Author: Richard Jones <email address hidden>
Date: Mon Aug 3 15:47:54 2015 +1000
JSCS Cleanup - style guide cleanup for Launch Instance wizard
Following John Papa's style guide /github. com/johnpapa/ angular- styleguide,
https:/
this patch refactors the Angular code for Launch Instance wizard.
Note that the construction of the Launch Instance wizard precludes
applying JP's "controller as" rule to the top level wizard controller
itself; doing so breaks the *many* implicit parent accesses throughout
the wizard sub controllers (implicit parent scope accesses are not
possible using the "controller as" style). Fixing that is potentially
a flow-on tech-debt fix that is outside of the scope of this
patch - it'll be a bunch of work!
I also noticed a trivial bugfix while addressing this. It could be
broken out into a separate patch, but we have enough patches already ;)
Change-Id: Ie6a1fdca1da602 59adbb65c36a982 9b001ae752b Implements: blueprint jscs-cleanup
Partially-
Closes-Bug: 1481135