Escape key doesn't work in all dialogues

[Kyromaster]

The escape key works e.g. in the options dialogue to exit and go back.
In both "single player" and "multiplayer" (and perhaps more) dialogues it doesn't work.

[Hans Joachim Desserud (hjd)]

Thanks for reporting.

Confirmed in r7502. This has been annoying me as well.

[Hans Joachim Desserud (hjd)]

GunChleoc: Thanks for working on this issue.

Something in the patch in r7510 broke clang compilation [1][2]:
In file included from /«PKGBUILDDIR»/src/ui_fsmenu/fileview.h:26:
/«PKGBUILDDIR»/src/ui_fsmenu/base.h:44:11: error: value of type 'UI::Panel::Returncodes' is not implicitly convertible to 'int'
                kBack = UI::Panel::Returncodes::kBack,
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/«PKGBUILDDIR»/src/ui_fsmenu/base.h:45:9: error: value of type 'UI::Panel::Returncodes' is not implicitly convertible to 'int'
                kOk = UI::Panel::Returncodes::kOk,
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings and 2 errors generated.

Could you take a look at it? :)

[1] https://code.launchpad.net/~hjd/+recipe/widelands-clang-compilation-canary
[2] https://launchpadlibrarian.net/214068223/buildlog_ubuntu-trusty-amd64.widelands_1%3A18-ppa0-bzr7510-201508101301~ubuntu14.04.1_BUILDING.txt.gz

[GunChleoc (gunchleoc)]

I have merged a fix - please reactivate this bug if it doesn't work.

[Hans Joachim Desserud (hjd)]

GunChleoc: Seems to work now (both building, and when I hit escape in various dialogs/menues). :)

In case someone are curious that there's some new build failures in Ubuntu Wily with either GCC or Clang: Wily is currently undergoing the GCC5 transition. Since GCC5 introduces a new c++11 ABI (see https://wiki.debian.org/GCC5 for more information on this), all libraries/packages/everything needs to be rebuilt to ensure they are able to build and work with the new ABI. Since this is an ongoing process, build failures encountered in the development version may not be (entirely) our fault.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.