swiftclient test code use assertEquals()

Bug #1480776 reported by Hiroshi Miura
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-swiftclient
Fix Released
Undecided
Unassigned

Bug Description

A swiftclient's test code uses a couple of lines of assertEquals() that deprecated in Py3.

It is guided to avoid it in OpenStack Style guidelines.

[H234] assertEquals() logs a DeprecationWarning in Python 3.x, use assertEqual() instead. The same goes for assertNotEquals().

Revision history for this message
Rui Zang (rui-zang) wrote :

Could you specify which test code?

Changed in python-swiftclient:
assignee: nobody → Rui Zang (rui-zang)
Rui Zang (rui-zang)
Changed in python-swiftclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-swiftclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209319

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-swiftclient (master)

Change abandoned by Rui Zang (<email address hidden>) on branch: master
Review: https://review.openstack.org/209319
Reason: someone else has already been working on the same change

Rui Zang (rui-zang)
Changed in python-swiftclient:
assignee: Rui Zang (rui-zang) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-swiftclient (master)

Reviewed: https://review.openstack.org/208331
Committed: https://git.openstack.org/cgit/openstack/python-swiftclient/commit/?id=be0f1aad8a5ed6f8d61016902c713db609ad834c
Submitter: Jenkins
Branch: master

commit be0f1aad8a5ed6f8d61016902c713db609ad834c
Author: Hiroshi Miura <email address hidden>
Date: Mon Aug 3 12:20:44 2015 +0900

    change deprecated assertEquals to assertEqual

    fix against H234: assertEquals() logs a DeprecationWarning
    in Python3.x. use assertEqual() instead.

    Closes-bug: #1480776

    Change-Id: Iffda6bb5f2616d4af4567eeea37bb26531e34371
    Signed-off-by: Hiroshi Miura <email address hidden>

Changed in python-swiftclient:
status: In Progress → Fix Committed
Changed in python-swiftclient:
milestone: none → 2.6.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-swiftclient 2.6.0

This issue was fixed in the openstack/python-swiftclient 2.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.