plugins no longer sync to all nodes

[Matthew Mosesohn]

This appears to be some sort of change in default behavior in the last 1-2 weeks. Prior to FF, all plugins synced to all nodes, regardless of role. Now, plugins can't call tasks from other plugins. Astute fails with the following error:
http://paste.openstack.org/show/XtDlyeFOWkvz0pFnSQEb/

In the case of my example, the manifests from detach-database plugin don't sync to the standalone-keystone role from detach-keystone plugin.
https://github.com/mattymo/detach-keystone
https://github.com/mattymo/detach-database

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "7.0"
  openstack_version: "2015.1.0-7.0"
  api: "1.0"
  build_number: "120"
  build_id: "2015-07-31_21-27-19"
  nailgun_sha: "0261b86bd0615d15531e6c8413ad276c5df385bf"
  python-fuelclient_sha: "71bb8fa87ee25f0c1bb84317884da7c917902a63"
  fuel-agent_sha: "1fe47720ba554818a0be707f2e16281791492d50"
  fuel-nailgun-agent_sha: "1512b9af6b41cc95c4d891c593aeebe0faca5a63"
  astute_sha: "f05bf102bbf8038066280a465a19a4dd1f75192d"
  fuel-library_sha: "ce219326ecce45020bd26f0b8765949c85ade83e"
  fuel-ostf_sha: "f73608d0e31d0a02a7fad6c048e931b7deef148e"
  fuelmain_sha: "7a374fbd1f5ebde943cb391a4f71b94888ce4a15"

[Matthew Mosesohn (raytrac3r)]

I should point out that controller gets the deployment_scripts from both plugins, while the custom roles from each plugin only gets its respective deployment_scripts.

[Ihor Kalnytskyi (ikalnytskyi)]

> This appears to be some sort of change in default behavior in the last 1-2 weeks.

No, it's not. It was *always* a default behavior. We sync plugins only on those nodes where plugin is intended to be used.

If you try to deal with one plugin from another one, you probably doing something wrong. You should not rely on this.. on *implicit* dependency.

Move it to Invalid, since it's not a bug but feature by design.

[Matthew Mosesohn (raytrac3r)]

There's no way to explicitly depend on another plugin, but there are cases where it's perfectly logical:
1 - setting database_vip to an external host from a plugin
2 - running rabbitmq from a dedicated role and needing to set amqp_nodes for all roles -- but you can't set it for plugins