Remove dup custom style imports
Bug #1480427 reported by
Shaoquan Chen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Medium
|
Diana Whitten |
Bug Description
Previously @import "/custom/styles"; has a comment of "// Custom Style Variables " which make it looks like a scss file with only variables, in that case it should be import to each scss file that will be injected to _stylesheet.html directly. Confirm with devs, "/custom/styles" should only include custom styles, than it should be imported only once.
Also, we need to make sure, /custom/styles should come at the very bottom of the combined css file.
Changed in horizon: | |
assignee: | Shaoquan Chen (sean-chen2) → Rajat Vig (rajatv) |
Changed in horizon: | |
milestone: | none → mitaka-3 |
importance: | Undecided → Medium |
Changed in horizon: | |
assignee: | Diana Whitten (hurgleburgler) → Timur Sufiev (tsufiev-x) |
Changed in horizon: | |
assignee: | Timur Sufiev (tsufiev-x) → Diana Whitten (hurgleburgler) |
Changed in horizon: | |
assignee: | Diana Whitten (hurgleburgler) → Timur Sufiev (tsufiev-x) |
Changed in horizon: | |
assignee: | Timur Sufiev (tsufiev-x) → Diana Whitten (hurgleburgler) |
Changed in horizon: | |
assignee: | Diana Whitten (hurgleburgler) → Richard Jones (r1chardj0n3s) |
Changed in horizon: | |
assignee: | Richard Jones (r1chardj0n3s) → Diana Whitten (hurgleburgler) |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/208017
Review: https:/