Not all commands in fuel upgrade script has stderr redirection

Bug #1480368 reported by Maksym Strukov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Ruslan Aliev

Bug Description

From this: https://bugs.launchpad.net/fuel/+bug/1480282

System test showed following error message:

===
Traceback
... skipped ...
AssertionError: Upgrade script fails with next message {here must be stderr output}
===

But fuel-upgrade.log contain more usable error message:

===
2015-07-31 05:37:49 ERROR 6464 (upgrade) HostSystemUpgrader: failed to upgrade: "Shell command executed with "1" exit code: yum install -v -y fuel-7.0.0 "
Traceback (most recent call last):
  File "/var/upgrade/.fuel-upgrade-venv/lib/python2.6/site-packages/fuel_upgrade/upgrade.py", line 82, in run
    upgrader.upgrade()
  File "/var/upgrade/.fuel-upgrade-venv/lib/python2.6/site-packages/fuel_upgrade/engines/host_system.py", line 97, in upgrade
    self.install_packages()
  File "/var/upgrade/.fuel-upgrade-venv/lib/python2.6/site-packages/fuel_upgrade/engines/host_system.py", line 143, in install_packages
    utils.exec_cmd('yum install -v -y {0}'.format(package))
  File "/var/upgrade/.fuel-upgrade-venv/lib/python2.6/site-packages/fuel_upgrade/utils.py", line 61, in exec_cmd
    _wait_and_check_exit_code(cmd, child)
  File "/var/upgrade/.fuel-upgrade-venv/lib/python2.6/site-packages/fuel_upgrade/utils.py", line 112, in _wait_and_check_exit_code
    'exit code: {1} '.format(exit_code, cmd))
ExecutedErrorNonZeroExitCode: Shell command executed with "1" exit code: yum install -v -y fuel-7.0.0
===

Therefore, not all commands in fuel upgrade script has stderr redirection.

Maksym Strukov (unbelll)
Changed in fuel:
status: New → Confirmed
Maksym Strukov (unbelll)
description: updated
tags: added: feature-upgrade
removed: system-tests
summary: - def run_script logging errors without stderr
+ Not all commands in fuel upgrade script has stderr redirection
Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/7.0.x
Dmitry Pyzhov (dpyzhov)
tags: added: low-hanging-fruit
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Ruslan Aliev (raliev)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Ruslan Aliev (raliev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-upgrade (master)

Fix proposed to branch: master
Review: https://review.openstack.org/241314

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-upgrade (master)

Change abandoned by Ruslan Aliev (<email address hidden>) on branch: master
Review: https://review.openstack.org/241314

Ruslan Aliev (raliev)
Changed in fuel:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.