OpenStack-Ansible

When a playbook fails in run-upgrade.sh, failure is not reported appropriately

Bug #1480342 reported by Ian Cordasco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
High
Ian Cordasco
Kilo
Fix Released
High
Ian Cordasco
OpenStack-Ansible 11.1.0
Trunk
Fix Released
High
Ian Cordasco

Bug Description

If a playbook in RUN_TASKS fails, the condition in run_lock does not catch that it failed appropriately. Thus run-upgrade.sh does not properly report that the upgrade was a failure and the only indication of failure comes from the ansible output.

Ian Cordasco (icordasc)
Changed in openstack-ansible:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Ian Cordasco (icordasc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/207936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (kilo)

Reviewed: https://review.openstack.org/207936
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=8a106d184a566f1baed616aee7747d5f2d581c1b
Submitter: Jenkins
Branch: kilo

commit 8a106d184a566f1baed616aee7747d5f2d581c1b
Author: Ian Cordasco <email address hidden>
Date: Fri Jul 31 09:50:57 2015 -0500

    Use playbook status to report upgrade failure

    Previously, we simply checked $? which at that point would be the exit
    status of echo, not openstack-ansible. By recording the actual
    openstack-ansible exit status, we can properly report failures of the
    upgrade script.

    Closes-bug: 1480342
    Change-Id: Icf43bea84660e4160a2dfcdb4ac93055340b3573

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/208607

Changed in openstack-ansible:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/208607
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=58d0daef9bd97439abba8fbfc9e63f2a8b0884cc
Submitter: Jenkins
Branch: master

commit 58d0daef9bd97439abba8fbfc9e63f2a8b0884cc
Author: Ian Cordasco <email address hidden>
Date: Fri Jul 31 09:50:57 2015 -0500

    Use playbook status to report upgrade failure

    Previously, we simply checked $? which at that point would be the exit
    status of echo, not openstack-ansible. By recording the actual
    openstack-ansible exit status, we can properly report failures of the
    upgrade script.

    Closes-bug: 1480342
    Change-Id: Icf43bea84660e4160a2dfcdb4ac93055340b3573
    (cherry picked from commit 8a106d184a566f1baed616aee7747d5f2d581c1b)

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.