Add tests for python-fuelclient into BVT tests

Bug #1480224 reported by Sebastian Kalinowski
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Egor Kotko

Bug Description

It would be nice to include one basic test (for example: list existing envs) for "fuel" and "fuel2" commands.
This would help us with checking in BVT that there are no issues with fuelclient like broken/conflicting dependencies installed.

Tags: area-qa
Changed in fuel:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Nastya Urlapova (aurlapova) wrote :

Sebastian, why you don't want to include such tests into review test set?

Changed in fuel:
status: Confirmed → Incomplete
assignee: Fuel QA Team (fuel-qa) → Sebastian Kalinowski (prmtl)
Revision history for this message
Sebastian Kalinowski (prmtl) wrote :

We have it, but they use requirements downloaded from PyPI and they are run in isolated environment.

Those tests that will be run during BVT would detect if there is something wrong with fuelclient after installing it on Fuel Master, where requirements are taken from installed RPM packages and may suffer from different bugs.

Changed in fuel:
status: Incomplete → New
assignee: Sebastian Kalinowski (prmtl) → Fuel QA Team (fuel-qa)
Revision history for this message
Nastya Urlapova (aurlapova) wrote :

I suggest to add this test on review state in fuel-web, I'll talk with devops team.

Artem Roma (aroma-x)
Changed in fuel:
status: New → Confirmed
Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

+1 for adding these tests because wrong packaging already caused several problems with Fuel Client installed on a master node

Revision history for this message
Nastya Urlapova (aurlapova) wrote :

Moved to 8.0, related to reconfiguration of BVT.

Changed in fuel:
milestone: 7.0 → 8.0
Dmitry Pyzhov (dpyzhov)
tags: added: area-qa
Egor Kotko (ykotko)
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Egor Kotko (ykotko)
Revision history for this message
Egor Kotko (ykotko) wrote :

Before starting the implementation I suppose to include the test into review test set if there is no objections.

Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

@Egor: I would oppose that -- in order to test Fuel Client there's absolutely no need to build a master node with all its components and run heavy tests. It's sufficient for Fuel Client to run it against an instance of Nailgun in fake mode and check whether it interacts with Nailgun's API properly.

This bug does not describe tests for Fuel Client but for an ISO. ISOs' have to be checked according to the integrity checklist and two items that list is currently lacking are checks for Fuel Client to be installed properly along with its dependencies and that an installation of Fuel Client and installation of other components don't conflict.

In summary, these are integrity tests for an ISO, not for Fuel Client, this is why they have to be put to the BVT set but not to the review pipelines in Fuel Client.

Revision history for this message
Tatyanka (tatyana-leontovich) wrote :

@Roman, I believe Egor propose exactly the same, but with possibility to see the response before stages like merge code/ build iso with new code /waiting while deployment fails and so one. As about new bvt test, please confirm it with Nastya, from my side I am ok with checks extensions in current bvt tests (so that we just can add 5-lines checker)

Revision history for this message
Nastya Urlapova (aurlapova) wrote :

Let's add a small check to current smoke test.

Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

My major concern is waiting for a long time until the ISO gets tested before a patch to Fuel Client can be merged. Now it takes about 5 minutes and I don't want to increase that time.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/241146

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/241146
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=8b7634bfce6dfdbf07486f2ed42d5e1e68d6bfac
Submitter: Jenkins
Branch: master

commit 8b7634bfce6dfdbf07486f2ed42d5e1e68d6bfac
Author: Egor Kotko <email address hidden>
Date: Tue Nov 3 10:31:39 2015 +0100

    Add client check

    Adding additional check for client area
    in smoke_neutron test

    Change-Id: Iebd2f3970b1fb6eda49a8ab301cf56df99ba80c9
    Closes-bug: #1480224

Changed in fuel:
status: In Progress → Fix Committed
Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: fuel-qa non-release
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.