nova rbd driver features are hard-coded, it should be readable from ceph.conf

Bug #1480129 reported by Vikhyat Umrao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Vikhyat Umrao

Bug Description

In nova rbd driver rbd features are hard-coded.

                rbd.RBD().clone(src_client.ioctx,
                                     image.encode('utf-8'),
                                     snapshot.encode('utf-8'),
                                     dest_client.ioctx,
                                     dest_name,
                                     features=rbd.RBD_FEATURE_LAYERING)

If We see above given code we are just using RBD_FEATURE_LAYERING directly.
This restrict users to use only hard-coded RBD_FEATURE_LAYERING feature.

We should give a fix which should allow users to opt in to upcoming features that have not yet become default and users can specify features in ceph.conf and nova can read features information from ceph.conf.

Fix should be something like :

Rreading rbd_default_features from ceph.conf for rbd
features configuration, falling back to layering if nothing is found.

Tags: ceph
Revision history for this message
Vikhyat Umrao (vumrao) wrote :
Changed in nova:
assignee: nobody → Vikhyat Umrao (vumrao)
status: New → In Progress
tags: added: ceph
Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/186537
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fb3713ae0ebbe030586c00b4d17bff371215e831
Submitter: Jenkins
Branch: master

commit fb3713ae0ebbe030586c00b4d17bff371215e831
Author: Vikhyat Umrao <email address hidden>
Date: Fri May 29 00:46:32 2015 +0530

    RBD: Reading rbd_default_features from ceph.conf

    This patch enables reading rbd_default_features from ceph.conf for rbd
    features configuration, falling back to layering if nothing is found.

    Closes-Bug: #1480129

    Change-Id: I639f06d6375201bdf5d469953bd80644ef433c87

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-3 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.