version show request does nto consider CONF.osapi_compute_link_prefix for buidling links

Bug #1480009 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Ghanshyam Mann

Bug Description

version show request for both v2 and v2.1 (/v2 and /v2.1) does not consider the CONF.osapi_compute_link_prefix for buidling links's href.

Currently version view->build_version use base url directly for building the href for links - https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/versions.py#L70

Above should prepare href using CONF.osapi_compute_link_prefix as done for other links.

This was caught in newly added functional tests fails -

http://logs.openstack.org/39/201439/4/check/gate-nova-tox-functional/ff44cb5/testr_results.html.gz .

Changed in nova:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/207702

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/207702
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bf83370ce09c88839cb209a13794297993417cc9
Submitter: Jenkins
Branch: master

commit bf83370ce09c88839cb209a13794297993417cc9
Author: ghanshyam <email address hidden>
Date: Wed Aug 19 17:06:32 2015 +0900

    Fix link's href to consider osapi_compute_link_prefix

    Version show request for both v2 and v2.1 (/v2 and /v2.1) does not
    consider the CONF.osapi_compute_link_prefix for buidling links's href.

    Above should prepare href using CONF.osapi_compute_link_prefix as done
    for other links.

    Previously functional tests of specific versions
    were not present so it was not caught.

    Closes-Bug: 1480009

    Change-Id: I54a09d2c56efb0a05832e57313917177b770c8cb

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-3 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.