Little improvement of errors show on volume Extend form

Bug #1480001 reported by Zhenguo Niu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Zhenguo Niu

Bug Description

Now when extending a volume to a new size which is less then the current
one, we will pop up an error warning message on the top of the form instead
of beside the new size field. now change to use field specified error class
for more accurate.

And as Kirill Zaitsev suggested, it
would be even better if we could incorporate https://docs.djangoproject.com/en/1.8/ref/forms/api/#django.forms.Form.add_error, which would not make us fiddle with form internals. but it was only added in django 1.7, and we support up to 1.5 but moving forward with django support seems like a nice idea.

Changed in horizon:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Changed in horizon:
status: New → In Progress
Revision history for this message
Zhenguo Niu (niu-zglinux) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/200158
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5d45cef785be30265ea65685bc798c7ef3f772e3
Submitter: Jenkins
Branch: master

commit 5d45cef785be30265ea65685bc798c7ef3f772e3
Author: Zhenguo Niu <email address hidden>
Date: Thu Jul 9 23:42:34 2015 +0800

    Use form field errors on volume Extend form

    Now when extending a volume to a new size which is less then the current
    one, we will pop up an error warning message on the top of the form instead
    of beside the new size field. now change to use field specified error class
    for more accurate.

    Closes-Bug: #1480001
    Change-Id: I2ee1a562bf548e78d657a3c5bd3307eacf6a3ab1

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Low
milestone: none → liberty-3
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.