Implement introspect for evpn information

Bug #1479430 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Released
Wishlist
Nischal Sheth
Trunk
Fix Committed
Wishlist
Nischal Sheth

Bug Description

Implement new introspect command to show evpn information.

This should include the following summary info per evpn table:

- Number of unicast routes
- Number of IM routes

Optionally, a detailed version should also display a list (per table
of all the RNVEs (regular PEs), AR-Replicators (TSNs), a list of leafs
for each AR-Replicator (list of TORs using a TSN).

Should also support pagination of output.
Should return a fixed number of entries per page.
Should not examine an unlimited number of tables in one
Task run when a filter is specified.

Nischal Sheth (nsheth)
description: updated
description: updated
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/13012
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/13013
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13013
Committed: http://github.org/Juniper/contrail-controller/commit/9057a6d96ed086a953fcfda4c43163f276222ee0
Submitter: Zuul
Branch: master

commit 9057a6d96ed086a953fcfda4c43163f276222ee0
Author: Nischal Sheth <email address hidden>
Date: Tue Aug 11 09:32:22 2015 -0700

Implement introspect for evpn information

Limit the maximum number of entries displayed on a single page for
both regular and summary requests. A next_batch link is generated
if there are more entries to be displayed.

Also limit maximum number of entries examined in one invocation of
the callback routine. This comes into play when there is a search
string specified and many entries don't match it. A partial page
is saved in user-allocated data and the next invocation of callback
appends to it. This is repeated till there's a full page or there
are no more entries in the table.

Following changes are implemented:

- Count number of unicast and inclusive multicast routes in EvpnTable
- Use class template BgpShowHandler to avoid code duplication
- Implement iteration limit to avoid hogging CPU from introspect
- Reuse show routing instance typed tests for evpn table introspect

Pending changes:

- Add more information to response for non-summary request
- Add unit tests to verify the contents of said response

Change-Id: I5f10a33e37b5b356d575400dce12303e10394540
Partial-Bug: 1479430

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/13012
Committed: http://github.org/Juniper/contrail-controller/commit/7069594b59ff211e3d8abccfcc2487b2f929a867
Submitter: Zuul
Branch: R2.20

commit 7069594b59ff211e3d8abccfcc2487b2f929a867
Author: Nischal Sheth <email address hidden>
Date: Tue Aug 11 09:32:22 2015 -0700

Implement introspect for evpn information

Limit the maximum number of entries displayed on a single page for
both regular and summary requests. A next_batch link is generated
if there are more entries to be displayed.

Also limit maximum number of entries examined in one invocation of
the callback routine. This comes into play when there is a search
string specified and many entries don't match it. A partial page
is saved in user-allocated data and the next invocation of callback
appends to it. This is repeated till there's a full page or there
are no more entries in the table.

Following changes are implemented:

- Count number of unicast and inclusive multicast routes in EvpnTable
- Use class template BgpShowHandler to avoid code duplication
- Implement iteration limit to avoid hogging CPU from introspect
- Reuse show routing instance typed tests for evpn table introspect

Pending changes:

- Add more information to response for non-summary request
- Add unit tests to verify the contents of said response

Change-Id: I5f10a33e37b5b356d575400dce12303e10394540
Partial-Bug: 1479430

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/13411
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/13412
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13412
Committed: http://github.org/Juniper/contrail-controller/commit/dba486148bef8658b9a2d1293c8071f726377825
Submitter: Zuul
Branch: master

commit dba486148bef8658b9a2d1293c8071f726377825
Author: Nischal Sheth <email address hidden>
Date: Fri Aug 28 09:50:03 2015 -0700

Add more information to evpn introspect

Following changes are implemented:

- Add info about regular NVEs, AR replicators and AR Leafs
- Add test to verify introspect response

Change-Id: I2ad1d1774122639f3ff388f1f61ed1d9eb2c1f35
Closes-Bug: 1479430

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/13411
Committed: http://github.org/Juniper/contrail-controller/commit/bc0e27a5af4da5e99bb524c52587a0406ccb85b3
Submitter: Zuul
Branch: R2.20

commit bc0e27a5af4da5e99bb524c52587a0406ccb85b3
Author: Nischal Sheth <email address hidden>
Date: Fri Aug 28 09:50:03 2015 -0700

Add more information to evpn introspect

Following changes are implemented:

- Add info about regular NVEs, AR replicators and AR Leafs
- Add test to verify introspect response

Change-Id: I2ad1d1774122639f3ff388f1f61ed1d9eb2c1f35
Closes-Bug: 1479430

Linda Lee (lindalee)
tags: added: bms customer
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13927
Submitter: Vinay Vithal Mahuli (<email address hidden>)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.