hash_bigkey.c in libc being compiled with missing MIN macro

[Andre Vieira]

Hello,
trying to link my program I am getting an error message, __big_insert: undefined reference to MIN.
The symbol is undefined in the libc.a

arm-none-eabi-nm libc.a | grep -B 30 MIN
lib_a-hash_bigkey.o:
         U __add_ovflpage
00000000 T __big_delete
00000000 T __big_insert
00000000 T __big_keydata
00000000 T __big_return
00000000 T __big_split
         U __call_hash
00000000 t collect_data
00000000 t collect_key
         U __errno
00000000 T __find_bigpair
00000000 T __find_last_page
         U free
         U __free_ovflpage
         U __get_buf
         U malloc
         U memcmp
         U memmove
         U MIN

and MIN is not defined in the libc.a, arm-none-eabi-nm --defined-only libc.a | grep MIN (no output).

Probably it has a connection with the including #include <sys/param.h> in newlib file hash_bigkey.c. The ARM port does define MIN MAX macros as other targets do.

[Andre Vieira (andre-simoesdiasvieira)]

Submitted patch for approval upstream:
https://sourceware.org/ml/newlib/2015/msg00595.html

[Thomas Preud'homme (thomas-preudhomme)]

Fix has been committed in newlib on August 2015 and is thus present since our 2015Q3 release. Marking the bug as fix released.