delete alarm returns 500 even it success

[Mehdi Abaakouk]

Hi,

Deleting an alarm returns 500 when it success:

2015-07-29 09:04:51.551315 2015-07-29 09:04:51.551 30355 ERROR wsme.api [req-e52d9eee-a0c0-42a3-9794-50403b9a4176 - - - - -] Server-side error: "'NoneType' object is not iterable". Detail:
2015-07-29 09:04:51.551338 Traceback (most recent call last):
2015-07-29 09:04:51.551343
2015-07-29 09:04:51.551345 File "/usr/local/lib/python2.7/dist-packages/wsmeext/pecan.py", line 84, in callfunction
2015-07-29 09:04:51.551348 result = f(self, *args, **kwargs)
2015-07-29 09:04:51.551351
2015-07-29 09:04:51.551353 File "/vagrant/stack-master/aodh/aodh/api/controllers/v2/alarms.py", line 617, in delete
2015-07-29 09:04:51.551355 alarm_object.delete_actions()
2015-07-29 09:04:51.551358
2015-07-29 09:04:51.551360 File "/vagrant/stack-master/aodh/aodh/api/controllers/v2/alarms.py", line 427, in delete_actions
2015-07-29 09:04:51.551362 self.insufficient_data_actions):
2015-07-29 09:04:51.551365
2015-07-29 09:04:51.551368 TypeError: 'NoneType' object is not iterable

Cheers,

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/207140

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/207140
Committed: https://git.openstack.org/cgit/openstack/aodh/commit/?id=b40b4513e61cd76a11e031d5b77bffbda1d012f6
Submitter: Jenkins
Branch: master

commit b40b4513e61cd76a11e031d5b77bffbda1d012f6
Author: Mehdi Abaakouk <email address hidden>
Date: Wed Jul 29 19:36:35 2015 +0200

    api: fix alarm deletion and update

    The API allow the actions to be null.

    This allow the alarm to be deleted and updated in this case.

    Closes bug: #1479274

    Change-Id: I0e53c39e9b6c9c80537ac646fb5695177eeb69d1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/209441

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/209441
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=74c393a827c9b633b1592f4f51434936e42a0f85
Submitter: Jenkins
Branch: master

commit 74c393a827c9b633b1592f4f51434936e42a0f85
Author: Mehdi Abaakouk <email address hidden>
Date: Wed Aug 5 12:17:09 2015 +0200

    api: fix alarm deletion and update

    The API allow the actions to be null.

    This allow the alarm to be deleted and updated in this case.

    Backported from:

    https://github.com/openstack/aodh/commit/b40b4513e61cd76a11e031d5b77bffbda1d012f6

    Closes bug: #1479274

    Change-Id: Id29ede93951e9d21bf5e6416955ae096a1259d72