redundant argument in container rpc api

Bug #1479108 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Lin Yang

Bug Description

In the RPC API https://github.com/openstack/magnum/blob/master/magnum/conductor/api.py , there is a method as below:

def container_create(self, name, container_uuid, container):

The argument 'name' and 'container_uuid' is redundant, since it can be retrieve from container object (e.g. container.name or container.uuid). We need to remove them.

hongbin (hongbin034)
tags: added: low-hanging-fruit
Lin Yang (lin-a-yang)
Changed in magnum:
assignee: nobody → Lin Yang (lin-a-yang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206970

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/206970
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=c57c42a7504b707a755de6588b4929851700a173
Submitter: Jenkins
Branch: master

commit c57c42a7504b707a755de6588b4929851700a173
Author: Lin Yang <email address hidden>
Date: Wed Jul 29 18:17:37 2015 +0800

    Remove redundant argument in container_create api

    The argument 'name' and 'container_uuid' is redundant, since it can be retrieve
    from container object.

    Change-Id: I691ba046f03ba8179903f51a602c22d4e0501178
    Closes-Bug: #1479108

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.