Comments in k8s template needs update

Bug #1479099 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
vincent

Bug Description

In this file https://github.com/openstack/magnum/blob/master/magnum/templates/heat-kubernetes/kubecluster.yaml , the comments for the 'kube_minions' resource group is as below:

  ######################################################################
  #
  # kubernetes minions. This is an autoscaling group that will initially
  # create <number_of_minions> minions, and will scale up to
  # <max_number_of_minions> based on CPU utilization.
  #

However, it is not correct. First, it is not autoscaling group, it is actually a resource group. Second, it won't scale based on CPU utilizaiton, it needs to be manually scaled. We need to update the comments accordingly.

hongbin (hongbin034)
tags: added: low-hanging-fruit
vincent (minsheng-l)
Changed in magnum:
assignee: nobody → vincent (minsheng-l)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206800

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/206800
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=98207690a7a80977415a846236147ed2d2e2d7c0
Submitter: Jenkins
Branch: master

commit 98207690a7a80977415a846236147ed2d2e2d7c0
Author: vincent <email address hidden>
Date: Wed Jul 29 10:56:14 2015 +0800

    update comments in k8s template

    fix the group and scale-up description about kubernetes minions

    Closes-Bug: #1479099

    Change-Id: I611cbd9a463c711a368de6b2a75a4e7398ecd2b2

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.