Collect dashboard app specific code in static/app/

Bug #1478717 reported by Tyr Johanson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Unassigned

Bug Description

The application openstack_dashboard has code that lives in two main locations:

1) horizon/openstack_dashboard/dashboards/ - this is code that is specific to a particular dashboard

2) horizon/openstack_dashboard/static/app/ - this is code specific to this application, but needed by two or more dashboards

This bug moves the Angular code that semanticaly belongs to the application together into the openstack_dashboard/static/app/ location.

Changed in horizon:
assignee: nobody → Tyr Johanson (tyr-6)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206760

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/197353
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=511634e9a85987ef0f83e578d2e2f2995db78d20
Submitter: Jenkins
Branch: master

commit 511634e9a85987ef0f83e578d2e2f2995db78d20
Author: Shaoquan Chen <email address hidden>
Date: Thu Jul 9 15:20:57 2015 -0700

    Dashboard ReOrg - Move tech-debt into app/

    This patch relocates the 'tech-debt' directory because
    it is application specific, but not a dashboard, nor a part of core
    logic of the application.

    Co-Authored-By: Tyr Johanson <email address hidden>
    Co-Authored-By: Shaoquan Chen <email address hidden>

    Change-Id: I141782f62ac1527e82666786b5af2aa790efa7c4
    Partial-Bug: #1478717

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/197330
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0d4cf1661e1afbb555ad234a879676a05b076763
Submitter: Jenkins
Branch: master

commit 0d4cf1661e1afbb555ad234a879676a05b076763
Author: Shaoquan Chen <email address hidden>
Date: Thu Jul 9 11:24:05 2015 -0700

    Dashboard ReOrg - Move APIs into app/core

    This patch relocates the 'openstack-service-api' directory because
    they are application specific, but needed by multiple dashboards.

    Co-Authored-By: Tyr Johanson <email address hidden>
    Co-Authored-By: Shaoquan Chen <email address hidden>

    Change-Id: Ie5455f3ca4cfaacb99cbccd66c95fb3ad31da272
    Partial-Bug: #1478717

Changed in horizon:
assignee: Tyr Johanson (tyr-6) → Richard Jones (r1chardj0n3s)
Changed in horizon:
assignee: Richard Jones (r1chardj0n3s) → Shaoquan Chen (sean-chen2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209346

Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Tyr Johanson (tyr-6)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/209613

Changed in horizon:
assignee: Tyr Johanson (tyr-6) → Shaoquan Chen (sean-chen2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/197234
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=87e386aea8b78ff0f38948bc3d82e953823b8125
Submitter: Jenkins
Branch: master

commit 87e386aea8b78ff0f38948bc3d82e953823b8125
Author: Tyr Johanson <email address hidden>
Date: Tue Jun 30 13:08:37 2015 -0600

    Dashboard ReOrg - Relocate Launch Instance module

    This patch relocates the 'launch-instance' directory.

    Continuing re-organization of the Launch Instance angular code
    to move it into the correct place for plugins, namely
    openstack_dashboard/dashboards/project/

    This patch attempts to divide https://review.openstack.org/#/c/191592
    into smaller, more easily reviewable pieces.

    Co-Authored-By: Shaoquan Chen <email address hidden>
    Co-Authored-By: Tyr Johanson <email address hidden>

    Change-Id: I426c77d704ed9114ce9ae148b5fdec4e381f0f68
    Partial-Bug: 1478717

Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Tyr Johanson (tyr-6)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/206760
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d0182f2493d3727eb85f0ebadcced9a6befcf18e
Submitter: Jenkins
Branch: master

commit d0182f2493d3727eb85f0ebadcced9a6befcf18e
Author: Tyr Johanson <email address hidden>
Date: Tue Jul 28 17:11:11 2015 -0600

    Dashboard ReOrg - hz.dashboard --> horizon.dashboard

    Rename all uses of 'hz.dashboard' in Angular code to
    'horizon.dashboard'. There are two main reasons for
    this change:

    1. This is consistent with the pattern used for the
    horizon framework (horizon.framework)

    2. This aligns with the directory structure. 'horizon'
    is a directory name and maps to /horizon and indicates
    that the component is part of the horizon project. The
    abbreviation 'hz' is now only used for legacy code.

    Change-Id: Ic22d6b0819ed62b3af2656fcb167b08ac55857c2
    Partial-Bug: 1478717

Changed in horizon:
assignee: Tyr Johanson (tyr-6) → Shaoquan Chen (sean-chen2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/209613
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ba582536ecb4b22ebea4708caeea8df174168383
Submitter: Jenkins
Branch: master

commit ba582536ecb4b22ebea4708caeea8df174168383
Author: Tyr Johanson <email address hidden>
Date: Wed Aug 5 11:43:46 2015 -0600

    Dashboard ReOrg - Remove unused dashboard.module.js

    This patch removes dashboard.module.js because it is no longer used.

    Change-Id: I8568b998573de7c2ff197bdc7e4bb9a8cf6aa784
    Partial-Bug: 1478717

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/209346
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6583e95cb381cb1d74bcadd9bc9f533d0859df4a
Submitter: Jenkins
Branch: master

commit 6583e95cb381cb1d74bcadd9bc9f533d0859df4a
Author: Shaoquan Chen <email address hidden>
Date: Tue Aug 4 22:30:35 2015 -0700

    Dashboard ReOrg - retiring dashboard.scss

    dashboard.scss is no longer the root scss for app, it is app.scss
    now.

    Change-Id: Iefddec7961c9d1a424637d95ed35296227e7339a
    Partial-Bug: #1478717

Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Rob Cresswell (robcresswell)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/203862
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=319b370aa35bd40bfe4ee1f2439ed827ad0bfdd8
Submitter: Jenkins
Branch: master

commit 319b370aa35bd40bfe4ee1f2439ed827ad0bfdd8
Author: Tyr Johanson <email address hidden>
Date: Mon Jul 20 17:35:59 2015 -0600

    Angular docs - code theory and translation

    Updates to the angularjs.rst documentation which describe how
    Angular code is organized within Horizon framework and the
    Dashboard application.

    Also updates the documentation for translation to follow the current
    patterns.

    This completes the dashboard re-organization work planned for https://launchpad.net/bugs/1478717.

    View formatted output by:
    1. cd /horizon/doc/
    2. make html
    3. open file:///<path to horizon>/doc/build/html/topics/angularjs.html

    Change-Id: Icf892223af01211ad4f764708f925d0a94035f51
    Co-Authored-By: Tyr Johanson <email address hidden>
    Co-Authored-By: Rob Cresswell <email address hidden>
    Partially-Implements: blueprint angular-docs
    Closes-Bug: 1478717

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → High
milestone: none → liberty-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-rc1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.