ACQ: Fiscal Year Close-out operation does not check org unit

[Jennifer Pringle]

Evergreen 2.6 and 2.8

When performing fiscal year end close out in Evergreen the system does not do a check for org unit before moving encumbrances or left over money to the next fiscal year. This means if multiple libraries are using the same fund code (ie. AF, ANF) their encumbrances could end up attached to a fund that does not belong to their library.

The workaround for this is to ensure that every fund code in the system is unique.

Ideally Evergreen should check that the org unit ID for the new fund matches that of the old fund before moving any encumbrances or money during fiscal year close-out.

[Jason Stephenson (jstephenson)]

Confirming this in 3.0.8. We've seen this for a couple of years at CW MARS, but didn't track it down until this week. I'm working on a fix and should have a branch in a day or two.

[Jason Stephenson (jstephenson)]

One thing that I have noted in this process is if library rolls over or propagates funds before library b, then library b will have debits rolled over to library a's funds, even if library a does not roll over. This comes down to the check for rollover funds not including the org id in the acq.rollover_funds_by_org_tree function.

I do not know if other things are going on, but this is one thing that I can confirm happening.

[Jason Stephenson (jstephenson)]

I have pushed a branch that changes the acq.rollover_funds_by_org_tree function to take the fund's org into account when looking for new funds to rollover into. This fixes the issue in my testing (see the commit message for how I tested it).

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1478712-acq-rollover-by-org

[Jennifer Pringle (jpringle-u)]

I set up a bunch of fake acq data and tested this on two servers with the Concerto dataset.

On the server without the fix I did fiscal close out for 2018 for BR1 and then BR3. The encumbrances for BR3 ended up in the BR1 2019 fund that used the same code.

On the server with the fix I did fiscal close out for 2018 BR1 and then BR3 and my encumbrances for BR3 moved to the BR3 2019 fund.

The unspent money from the funds was returned to the funding sources and the spent money remained on the 2018 funds as expected.

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

[Chris Sharp (chrissharp123)]

Pushed to master, rel_3_0, and rel_3_1. Thanks Jason and Jennifer!

[Mike Rylander (mrylander)]

Pushed a follow-up commit to stamp the upgrade script: c1fac20422420e8a11cb950741f32b2f39fa4918