Get default quota value of a subproject is not ignoring default_quota_class conf

Bug #1478651 reported by Erickson Filipe Guedes dos Santos
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Erickson Filipe Guedes dos Santos

Bug Description

When getting the default quota value of a project, actually, the DBQuotaDriver is just checking if the default_quota_class CONF is set to True (As you can see here: https://github.com/openstack/cinder/blob/master/cinder/quota.py#L125). But, this default_quota_class values should not be loaded when getting default quota values to subprojects.

Changed in cinder:
assignee: nobody → Erickson Filipe Guedes dos Santos (ericksonfilipe)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206170

Changed in cinder:
status: New → In Progress
Revision history for this message
Vilobh Meshram (vilobhmm) wrote :

This needs to be fixed.

Changed in cinder:
importance: Undecided → Medium
milestone: none → liberty-2
Mike Perez (thingee)
Changed in cinder:
milestone: liberty-2 → liberty-3
Changed in cinder:
assignee: Erickson Filipe Guedes dos Santos (ericksonfilipe) → Vilobh Meshram (vilobhmm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/206170
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e2eb94bdbbe7dae57247cdf0e9f06debceb673cb
Submitter: Jenkins
Branch: master

commit e2eb94bdbbe7dae57247cdf0e9f06debceb673cb
Author: Erickson Santos <email address hidden>
Date: Mon Jul 27 14:52:47 2015 -0300

    Fix get default quota values for subprojects

    When getting the default quota value for a project, the DBQuotaDriver
    is just checking if the default_quota_class CONF is set to True.
    But this conf should not be considered when getting default quota
    values for subprojects.

    Previously, when we asked for the default quota values of a
    subproject, the default quota values of the root project was returned.

    Co-Authored-By: Vilobh Meshram <email address hidden>

    Change-Id: Ib88bafca915dfd387086c353c25b2af037e6d50f
    Closes-bug: #1478651

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
assignee: Vilobh Meshram (vilobhmm) → Erickson Filipe Guedes dos Santos (ericksonfilipe)
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.