Pioneer mode only works in Shade skin

[Mannex]

Running build 5442 on Linux Mint KDE.

Pioneer mode's blinking Cue and Play buttons don't seem to work for any skin other than the Shade skin. Simply loading a track into deck one should, as I understand it, have the cue button blinking at least.

[Daniel Schürmann (daschuer)]

This is simply to fix.
Just add the play_indicator connection:

<Connection>
     <ConfigKey>[Channel1],play_indicator</ConfigKey>
</Connection>

@Mannex: Do you have fun to adopt it yourselves?
Heres some hints:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow
or just ask :-)

[Mannex (russ-mannex)]

@Daniel, I'll check that out. I've poked around a bit in the interface XMLs, so it shouldn't be to difficult. Thanks.

[Mannex (russ-mannex)]

Just noticed that the channel numbers for these connections are hard-coded into the shade skin, but other connections use the seemingly more generic "Channel<Variable name="channum" />]" (or samplernum). Shouldn't they all use the generic version rather than a hard-coded one? Just a thought.

[Mannex (russ-mannex)]

And I assume the same connections should be plugged in for the cue indicators, only using cue_indicator instead, right? I'll see what I can do.

[Mannex (russ-mannex)]

Okay folks, I've put a pull request for changes on the LateNight skin. The Deere skin (love saying that) is a bit different, so I have to hunt around a bit later for that one. FYI, the changes were made to the res/skins/LateNight/deck_buttons.xml file as follows:

 <Connection>
  <ConfigKey>[Channel<Variable name="channum" />],cue_indicator</ConfigKey>
 </Connection>

was added in the CueToggleButton section under the other connections, and

 <Connection>
  <ConfigKey>[Channel<Variable name="channum" />],play_indicator</ConfigKey>
 </Connection>

as added in the play_cue_set section under the other connections. Please let me know if I've fouled up in some unforeseen and sinister way. Thanks!

[Mannex (russ-mannex)]

Oh, thanks *blush*. I'll get the Deere skin fixed this evening.

[Mannex (russ-mannex)]

Does anyone know where the play button connections are in the Deere skin files? I can't seem to locate them. I've got the cue button fixed, and I thought it would be in the same file, but no. I tried grepping for a few combinations that should have found it. Thanks.

[Daniel Schürmann (daschuer)]

Deere uses an extra layer of abstraction:
https://github.com/mixxxdj/mixxx/blob/3f854c1674084609497036ba92e1605a43fb492f/res/skins/Deere/deck_inner_column.xml#L104
https://github.com/mixxxdj/mixxx/blob/3f854c1674084609497036ba92e1605a43fb492f/res/skins/Deere/left_right_2state_button.xml

I think you need to introduce a new file:
left_right_display_2state_button.xml
featuring a new display_connection_control

Some hints:
do you know starting Mixxx with
mixxx --developer
enables a handy developer menu end extra large tool-tips.

[Mannex (russ-mannex)]

Thanks. That explains why I'm not seeing things that I thought I should. :)

[Daniel Schürmann (daschuer)]

Wait!
I have just noticed that esbandt, the Deere maintainer has already fixed the Pioneer mode in his private repro.
So there is no need for a Deere fix.
https://github.com/esbrandt/mixxx/blob/deere_updates/res/skins/Deere/left_right_display_2state_button.xml
Sorry.

[Mannex (russ-mannex)]

Ah, thank you! So, should I mark this as fixed?

[Daniel Schürmann (daschuer)]

please mark this "In Progress", until your PR is merged.

[Mannex (russ-mannex)]

Thanks. Done!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8171