typos(?) in create_snapshots_in_db

Bug #1478236 reported by Yusuke Hayashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Yusuke Hayashi

Bug Description

other variables are used in line 783 (snap) and 784 (snapshot) of cinder.volume.api.
Is it typo?

 773 try:
 774 for options in options_list:
 775 snapshot = objects.Snapshot(context=context, **options)
 776 snapshot.create()
 777 snapshot_list.append(snapshot)
 778
 779 QUOTAS.commit(context, reservations)
 780 except Exception:
 781 with excutils.save_and_reraise_exception():
 782 try:
 783 for snap in snapshot_list:
 784 snapshot.destroy()
 785 finally:
 786 QUOTAS.rollback(context, reservations)

Changed in cinder:
assignee: nobody → Yusuke Hayashi (hayashi-yusuke)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/205757

Changed in cinder:
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/205757
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=154b2542a4a4013fc6071c3ea56a2391787da2e7
Submitter: Jenkins
Branch: master

commit 154b2542a4a4013fc6071c3ea56a2391787da2e7
Author: Yusuke Hayashi <email address hidden>
Date: Sat Jul 25 21:49:33 2015 +0900

    typos(?) in create_snapshots_in_db

    Other variables are used in line 783 (snap) and 784 (snapshot)
    of cinder.volume.api.

    Since it looks typo, I fix it.

    Change-Id: I3f1aa3b71166e882c751362792fbf90477ecbd38
    Closes-Bug: #1478236

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-2 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.