Inefficient result filtering
Bug #1478102 reported by
Steve McLellan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Searchlight |
Fix Released
|
Medium
|
Steve McLellan |
Bug Description
After running the elasticsearch search, we pass the results through filter_results for each plugin in case there are sensitive fields or data transformations need doing in v1/search.py:
for plugin in self.plugins:
As the number of plugins (hopefully) grows, this gets less and less efficient, since all but one plugin will be a no-op for any given result but we're looping through the entire (potentially large) result set. Better would be handling the dispatch earlier; build up a dictionary of index-type -> filter_result function and run the results through it.
Changed in searchlight: | |
importance: | Undecided → Medium |
Changed in searchlight: | |
assignee: | nobody → Steve McLellan (sjmc7) |
Changed in searchlight: | |
milestone: | none → liberty-rc1 |
Changed in searchlight: | |
status: | Fix Committed → Fix Released |
Changed in searchlight: | |
milestone: | liberty-rc1 → 0.1.0.0 |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/207682
Review: https:/