nova.virt.block_device 'Failed to transform' error is spamming the logs since 7/19

[Matt Riedemann]

These:

http://logs.openstack.org/36/193236/10/check/gate-tempest-dsvm-full-ceph/5549dfc/logs/screen-n-cpu.txt.gz?level=TRACE

2015-07-23 17:06:29.296 ERROR nova.virt.block_device [req-148f8955-8c6d-4cd4-ba40-93734ea70349 tempest-AggregatesAdminTestJSON-483895825 tempest-AggregatesAdminTestJSON-205555307] Failed to transform: source_type: image, destination_type: local

There are tons of them:

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiRmFpbGVkIHRvIHRyYW5zZm9ybVwiIEFORCBtb2R1bGU6XCJub3ZhLnZpcnQuYmxvY2tfZGV2aWNlXCIgQU5EIHRhZ3M6XCJzY3JlZW4tbi1jcHUudHh0XCIiLCJmaWVsZHMiOltdLCJvZmZzZXQiOjAsInRpbWVmcmFtZSI6IjYwNDgwMCIsImdyYXBobW9kZSI6ImNvdW50IiwidGltZSI6eyJ1c2VyX2ludGVydmFsIjowfSwic3RhbXAiOjE0Mzc3NTA3Mjk0OTF9

3594 hits since 7/19, many different types of jobs, so it's not just that ceph job link above.

[Matt Riedemann (mriedem)]

Oh 7/19 is because that's when the error message was introduced:

https://review.openstack.org/#/c/180584/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/205583

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/205583
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e4113d0703a58958158c564ce183c40c124b9dcb
Submitter: Jenkins
Branch: master

commit e4113d0703a58958158c564ce183c40c124b9dcb
Author: Matt Riedemann <email address hidden>
Date: Fri Jul 24 15:20:07 2015 +0000

    Revert "Add error message to failed block device transform"

    This reverts commit 7a373e1be33879c39fae88fa6020e417abb55847

    The error log introduced here is spamming the logs in normal
    test runs.

    The _InvalidType extends _NotTransformable which is a
    marker exception type used for flow control and just means
    we can't convert the block device object, but it's
    clearly not an error since it's caught and there is a pass,
    so this is expected (and jobs aren't failing because of it).

    Change-Id: Ie86fb728fdc26cfc6a33c71c6b6ea87f0c577754
    Closes-Bug: #1478043