[dashboard] Too much ignores of pep8 rules.

Bug #1478002 reported by Kirill Zaitsev
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Kirill Zaitsev

Bug Description

Looking at the tox.ini dashboard currently ignores

[flake8]
# H104 File contains nothing but comments
# E111 indentation is not a multiple of four
# E113 unexpected indentation
# H236 Python 3.x incompatible __metaclass__, use six.add_metaclass()
# H238 old style class declaration, use new style (inherit from `object`)
# E265 block comment should start with '# '
# H405 multi line docstring summary not separated with an empty line
# H701 Empty localization string
ignore = H104,E111,E113,H236,H238,E265,H405,H701

This is really strange. Even E111 and E113 are ignored, which are the basis of pep8.

Tags: dashboard
Changed in murano:
assignee: nobody → Kirill Zaitsev (kzaitsev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/205566

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/205566
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=f847c50466a50bd5cbd3628f511438025b7b481a
Submitter: Jenkins
Branch: master

commit f847c50466a50bd5cbd3628f511438025b7b481a
Author: Kirill Zaitsev <email address hidden>
Date: Fri Jul 24 17:54:22 2015 +0300

    Enable hacking/flake8 rules

    This commit enables and fixes previously disabled E and F rules:

    * E111 indentation is not a multiple of four
    * E113 unexpected indentation
    * E265 block comment should start with '# '
    * H236 Python 3.x incompatible __metaclass__, use six.add_metaclass()
    * H238 old style class declaration, use new style (inherit from `object`)
    * H405 multi line docstring summary not separated with an empty line
    * H701 Empty localization string

    Change-Id: Ie0af0d450f81cb5bf274192e6fdce3e41ccb7f88
    Closes-Bug: #1478002

Changed in murano:
status: In Progress → Fix Committed
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
milestone: liberty-2 → 1.0.0
Changed in murano:
milestone: 1.0.0 → 1.0.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.