AttributeError when creating a new share without specifying a share type

Bug #1477789 reported by Hiroyuki Eguchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Hiroyuki Eguchi

Bug Description

A share_type is set to None, when creating a new share without specifying a share type.

So, An AttributeError will occur in share_type.get('extra_specs', {}).

Changed in manila:
assignee: nobody → Hiroyuki Eguchi (h-eguchi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/205331

Changed in manila:
status: New → In Progress
Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

Share type can not be None. All shares have some. Please, provide steps for reproducing.

Changed in manila:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/205331
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f89f0f2b69fd4d3ec315211fd9186d0d118650c3
Submitter: Jenkins
Branch: master

commit f89f0f2b69fd4d3ec315211fd9186d0d118650c3
Author: Hiroyuki Eguchi <email address hidden>
Date: Fri Aug 14 12:43:44 2015 +0900

    Fix AttributeError without share type provided

    A share_type is set to None, when creating a new share
    without specifying a share type and a default_share_type
    option is set to None.
    Make scheduler check presense of a share type and
    raise error if it is absent.
    The raised error is logged finally.

    Closes-Bug: #1477789
    Change-Id: I6cdf3ce3940af4095b8e6afca4861ad1c2fc4795

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-3 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.