snapcraft has many exit points
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Snapcraft |
Fix Released
|
Low
|
Sergio Schvezov |
Bug Description
I think it should be better to raise exceptions on many of these cases that exit with 1.
Then, the main method can catch the exceptions, and exit with 1.
For the cases that exit with 0, we should just return to the main caller.
elopio@
snapcraft/cmds.py: sys.exit(1)
snapcraft/cmds.py: sys.exit(0)
snapcraft/cmds.py: sys.exit(1)
snapcraft/cmds.py: sys.exit(1)
snapcraft/cmds.py: sys.exit(1)
snapcraft/
snapcraft/
snapcraft/
snapcraft/main.py: sys.exit(1)
snapcraft/main.py: sys.exit(0)
snapcraft/yaml.py: sys.exit(1)
snapcraft/yaml.py: sys.exit(1)
snapcraft/yaml.py: sys.exit(1)
snapcraft/
snapcraft/
Related branches
Changed in snapcraft: | |
status: | Fix Committed → Fix Released |
Leo, I would strongly recommend you to have a look at guacamole to organize all of snapcraft CLI handling. Let's discuss this next week. I would love to work with you to get this merged.