zaqar

Websocket doesn't handle invalid json request

Bug #1477610 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Undecided
Thomas Herve
zaqar 1.0.0 "liberty"

Bug Description

If I send a simple string over the websocket connection, I get the error server side: ValueError: No JSON object could be decoded

And no feedback on the client side. We should send a proper error message.

Revision history for this message
Thomas Herve (therve) wrote :

https://review.openstack.org/205077

Changed in zaqar:
assignee: nobody → Thomas Herve (therve)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/205077
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=0361a647d81a5345cfa0e03ce1426578a34f90c4
Submitter: Jenkins
Branch: master

commit 0361a647d81a5345cfa0e03ce1426578a34f90c4
Author: Thomas Herve <email address hidden>
Date: Thu Jul 23 16:21:46 2015 +0200

    Return the websocket response on invalid request

    When a non-JSON object is passed to the websocket connection the error
    is caught but wasn't returned, it is now.

    Change-Id: I47338355a362272d2b4faee230947db06d644a87
    Closes-Bug: #1477610

Changed in zaqar:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in zaqar:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in zaqar:
milestone: liberty-2 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.