dhcp._release_lease shouldn't stacktrace when a device isn't found since it could be legitimately gone

[Matt Riedemann]

http://logs.openstack.org/80/200380/3/gate/gate-tempest-dsvm-neutron-full/2b49b0d/logs/screen-q-dhcp.txt.gz?level=TRACE#_2015-07-22_09_30_43_303

This kind of stuff is really annoying in debugging failures in the gate since I think it's a known failure during cleanup of ports when deleting an instance, so we shouldn't stacktrace this and log as an error, just handle it in the code and move on.

2015-07-22 09:30:43.303 ERROR neutron.agent.dhcp.agent [req-c7faddea-956c-4544-8ec0-1f6e5029cae1 tempest-NetworksTestDHCPv6-1951433064 tempest-NetworksTestDHCPv6-996832218] Unable to reload_allocations dhcp for 301ef35d-2482-4a13-a088-f456958e878a.
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent Traceback (most recent call last):
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent File "/opt/stack/new/neutron/neutron/agent/dhcp/agent.py", line 115, in call_driver
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent getattr(driver, action)(**action_kwargs)
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent File "/opt/stack/new/neutron/neutron/agent/linux/dhcp.py", line 432, in reload_allocations
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent self._release_unused_leases()
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent File "/opt/stack/new/neutron/neutron/agent/linux/dhcp.py", line 671, in _release_unused_leases
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent self._release_lease(mac, ip, client_id)
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent File "/opt/stack/new/neutron/neutron/agent/linux/dhcp.py", line 415, in _release_lease
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent ip_wrapper.netns.execute(cmd, run_as_root=True)
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent File "/opt/stack/new/neutron/neutron/agent/linux/ip_lib.py", line 701, in execute
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent extra_ok_codes=extra_ok_codes, **kwargs)
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent File "/opt/stack/new/neutron/neutron/agent/linux/utils.py", line 138, in execute
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent raise RuntimeError(m)
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent RuntimeError:
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent Command: ['ip', 'netns', 'exec', u'qdhcp-301ef35d-2482-4a13-a088-f456958e878a', 'dhcp_release', 'tapcb2fa9dc-f6', '2003::e6ef:eb57:47b4:91cf', 'fa:16:3e:18:e6:78']
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent Exit code: 1
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent Stdin:
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent Stdout:
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent Stderr: cannot setup interface: No such device
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent
2015-07-22 09:30:43.303 8230 ERROR neutron.agent.dhcp.agent

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiU3RkZXJyOiBjYW5ub3Qgc2V0dXAgaW50ZXJmYWNlOiBObyBzdWNoIGRldmljZVwiIEFORCB0YWdzOlwic2NyZWVuLXEtZGhjcC50eHRcIiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiNjA0ODAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTQzNzU3NjE3ODQzNn0=

[Sridhar Gaddam (sridhargaddam)]

@Matt, if you plan to submit a patch please feel free to proceed. Otherwise, I'll look into this issue tomm'. Thanks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/205101

[Assaf Muller (amuller)]

No action required from Tempest folks, this is purely a Neutron bug.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/205101
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]