VMware: volume's vmdk uuid exists in instance's vmx file even after volume detach

[Vipin Balachandran]

Steps to reproduce:

* Attach volume with ID = foo to nova instance
* Verify instance VM's vmx file in ESX host (should contain entry volume-foo = <volume-vmdk-uuid>)
* Detach volume
* Verify instance VM's vmx file in ESX host (still contains entry volume-foo = <volume-vmdk-uuid>)

Expected behavior:

After volume detach, the vmx file shouldn't contain volume related entry.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/204622

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/204622
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=88721a65b5d2e07bba0e2b405c3cd93491d731dc
Submitter: Jenkins
Branch: master

commit 88721a65b5d2e07bba0e2b405c3cd93491d731dc
Author: Vipin Balachandran <email address hidden>
Date: Wed Jul 22 19:06:45 2015 +0530

    VMware: Delete vmdk UUID during volume detach

    During volume attach, the volume vmdk UUID is added to VM's
    extra config as a key-value pair "volume-<volume-UUID> =
    <volume-vmdk-UUID>". This is required to identify the vmdk
    to be removed during volume detach. But the key-value pair
    added during volume attach is not deleted during detach.
    This patch deletes the relevant key-value pair from VM's
    extra config during volume detach.

    Closes-Bug: #1477159
    Change-Id: Id4d5e2eede5e1d2418f301045fb2b3542a39b471