glance_nfs_client adding additional mount points

Bug #1477081 reported by Andy McCrae
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
High
Andy McCrae
Kilo
Fix Released
High
Andy McCrae
Trunk
Fix Released
High
Andy McCrae

Bug Description

The glance_nfs_client adds an additional (incorrect) mount point.

The handler adds a mount point which is incorrect, and the actual filesystems are not mounted just added to fstab.

Additionally the defaults/main.yml includes incorrect instruction on setting nfs_client up.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/204542

Changed in openstack-ansible:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/204542
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=c19915251f597242d54335d8c8f8e69012be2cb8
Submitter: Jenkins
Branch: master

commit c19915251f597242d54335d8c8f8e69012be2cb8
Author: Andy McCrae <email address hidden>
Date: Wed Jul 22 11:41:26 2015 +0100

    Fix glance_nfs_client setting

    glance_nfs_client adds 2 fstab entries, with then handler entry being
    incorrectly ordered (src and name are the wrong way around).

    This patch removes the redundant handler and moves the existing fstab
    task to use the "mount" module which will add the entry to fstab and
    ensure the filesystems are mounted.

    Additionally this fixes a documentation bug where an incorrect variable
    is referenced (glance_nfs_mounts).

    Change-Id: I6e0f964d4279800d31119f380a239e2c4ae61cb5
    Fixes-Bug: #1477081

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (kilo)

Reviewed: https://review.openstack.org/204954
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=07066b74020e3118dbd795a3c220093713445b27
Submitter: Jenkins
Branch: kilo

commit 07066b74020e3118dbd795a3c220093713445b27
Author: Andy McCrae <email address hidden>
Date: Wed Jul 22 11:41:26 2015 +0100

    Fix glance_nfs_client setting

    glance_nfs_client adds 2 fstab entries, with then handler entry being
    incorrectly ordered (src and name are the wrong way around).

    This patch removes the redundant handler and moves the existing fstab
    task to use the "mount" module which will add the entry to fstab and
    ensure the filesystems are mounted.

    Additionally this fixes a documentation bug where an incorrect variable
    is referenced (glance_nfs_mounts).

    Change-Id: I6e0f964d4279800d31119f380a239e2c4ae61cb5
    Fixes-Bug: #1477081
    (cherry-picked from commit c19915251f597242d54335d8c8f8e69012be2cb8)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.