Error while executing std.http: Circular reference detected

Bug #1477048 reported by Nikolay Makhotkin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Nikolay Makhotkin

Bug Description

Steps to reproduce:

1. Run action: mistral run-action std.http '{"url": "http://google.ru"}'

2. Get error:

ERROR (app) Circular reference detected
Traceback (most recent call last):

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 142, in _dispatch_and_reply
    executor_callback))

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 101, in reply
    self._send_reply(conn, reply, failure, log_failure=log_failure)

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 73, in _send_reply
    conn.direct_send(self.reply_q, rpc_common.serialize_msg(msg))

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/_drivers/common.py", line 285, in serialize_msg
    _MESSAGE_KEY: jsonutils.dumps(raw_msg)}

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_serialization/jsonutils.py", line 185, in dumps
    return json.dumps(obj, default=default, **kwargs)

  File "/usr/lib/python2.7/json/__init__.py", line 250, in dumps
    sort_keys=sort_keys, **kw).encode(obj)

  File "/usr/lib/python2.7/json/encoder.py", line 207, in encode
    chunks = self.iterencode(o, _one_shot=True)

  File "/usr/lib/python2.7/json/encoder.py", line 270, in iterencode
    return _iterencode(o, 0)

ValueError: Circular reference detected

Traceback (most recent call last):

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 142, in _dispatch_and_reply
    executor_callback))

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 186, in _dispatch
    executor_callback)

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 129, in _do_dispatch
    result = func(ctxt, **new_args)

  File "/home/kolyan/projects/mistral/mistral/engine/rpc.py", line 122, in start_action
    **params

  File "/home/kolyan/projects/mistral/mistral/utils/__init__.py", line 105, in _logged
    return func(*args, **kw)

  File "/home/kolyan/projects/mistral/mistral/engine/default_engine.py", line 127, in start_action
    async=False

  File "/home/kolyan/projects/mistral/mistral/engine/action_handler.py", line 150, in run_action
    async

  File "/home/kolyan/projects/mistral/mistral/engine/rpc.py", line 441, in run_action
    **kwargs

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/rpc/client.py", line 158, in call
    retry=self.retry)

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/transport.py", line 90, in _send
    timeout=timeout, retry=retry)

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 431, in send
    retry=retry)

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 422, in _send
    raise result

ValueError: Circular reference detected
Traceback (most recent call last):

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 142, in _dispatch_and_reply
    executor_callback))

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 101, in reply
    self._send_reply(conn, reply, failure, log_failure=log_failure)

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py", line 73, in _send_reply
    conn.direct_send(self.reply_q, rpc_common.serialize_msg(msg))

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_messaging/_drivers/common.py", line 285, in serialize_msg
    _MESSAGE_KEY: jsonutils.dumps(raw_msg)}

  File "/home/kolyan/projects/mistral/.tox/venv/local/lib/python2.7/site-packages/oslo_serialization/jsonutils.py", line 185, in dumps
    return json.dumps(obj, default=default, **kwargs)

  File "/usr/lib/python2.7/json/__init__.py", line 250, in dumps
    sort_keys=sort_keys, **kw).encode(obj)

  File "/usr/lib/python2.7/json/encoder.py", line 207, in encode
    chunks = self.iterencode(o, _one_shot=True)

  File "/usr/lib/python2.7/json/encoder.py", line 270, in iterencode
    return _iterencode(o, 0)

ValueError: Circular reference detected

The same error is received if action is called via workflow.

Changed in mistral:
assignee: nobody → Nikolay Makhotkin (nmakhotkin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/204558

Changed in mistral:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/204558
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=1db5ff44060a472902ad9c19169d3986de7fc687
Submitter: Jenkins
Branch: master

commit 1db5ff44060a472902ad9c19169d3986de7fc687
Author: Nikolay Mahotkin <email address hidden>
Date: Wed Jul 22 14:16:59 2015 +0300

    Fixing std.http action

     * The problem comes from JSON serializing. Cookies and
       datetime is not JSON serializable, so we need to
       preprocess them manually.

    Closes-Bug: #1477048

    Change-Id: I2dbd1463f1b3549f661c0dba46ab6f949c4fffb4

Changed in mistral:
status: In Progress → Fix Committed
Changed in mistral:
status: Fix Committed → Fix Released
Changed in mistral:
milestone: liberty-2 → liberty
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.