503 returned when missing subscription body

Bug #1477005 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Undecided
Thomas Herve

Bug Description

Just tried: "curl -X POST ... http://localhost:8888/v2/queues/queue/subscriptions" without a body. I got a 503 and the following traceback on the server side:

UnboundLocalError: local variable 'document' referenced before assignment

We should raise a 400 with a correct error message.

Thomas Herve (therve)
Changed in zaqar:
assignee: nobody → Thomas Herve (therve)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zaqar (master)

Fix proposed to branch: master
Review: https://review.openstack.org/204576

Changed in zaqar:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/204576
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=9c6e6a874ba9179c3f3424668894c0a1b660b946
Submitter: Jenkins
Branch: master

commit 9c6e6a874ba9179c3f3424668894c0a1b660b946
Author: Thomas Herve <email address hidden>
Date: Wed Jul 22 14:24:53 2015 +0200

    Handle missing document in subscription operations

    This handles requests without a body in the subscriptions APIs to raise
    correct errors.

    Change-Id: Ibfbbd23f26ea54dea142a6590465f86392e996d8
    Closes-Bug: #1477005

Changed in zaqar:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in zaqar:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in zaqar:
milestone: liberty-2 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.