Remove "additional_components" string from conditions.

[Denis Egorenko]

I've build custom iso [1] with my patch to puppet for Sahara [2] and then run bvt tests [3]. They were failed with error:

nailgun serializer failed TypeError: Value of settings:sahara.enabled.value is undefined. Set options.strict to false to allow undefined values.

Also were failed CI tests on this patch.

Current condition, which is using for checking Sahara service is:

https://review.openstack.org/#/c/202195/10/deployment/puppet/osnailyfacter/modular/sahara/tasks.yaml

settings:additional_components.sahara.value == true -> settings:sahara.enabled.value == true

So, we need rename this option in Nailgun at first.

[1] https://review.openstack.org/#/c/202195
[2] http://jenkins-product.srt.mirantis.net:8080/view/custom_iso/job/custom_7.0_iso/555/
[3] http://jenkins-product.srt.mirantis.net:8080/view/custom_iso/job/7.0.custom.ubuntu.bvt_2/128/

[Sebastian Kalinowski (prmtl)]

I don't think this bug is High (or even not a real "bug", rather wishlist). It doesn't cause any issues for deployment.
For me it's quite reasonable to use 'settings:additional_components.sahara.value' as Sahara is, well, additional component.
What other guys think?

[Vladimir Sharshov (vsharshov)]

According to Sebastian comment moving this to 8.0