stack resource-list does NotFound for ResourceGroups with CREATE_ERROR resources

[Steve Baker]

scenario: A stack with a ResourceGroup where a resource inside that group is in CREATE_FAILED, when that stack is deleted the following happens:

Calling heat resource-list results in a NotFound response even though heat stack-show confirms the stack exists

Resource.nested() may raise a NotFound exception, but heat.engine.api.format_stack_resource is not catching this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/204294

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/204302

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/204294
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c3f9337c11b78f98704dce9e76e2b74e9098670a
Submitter: Jenkins
Branch: master

commit c3f9337c11b78f98704dce9e76e2b74e9098670a
Author: Steve Baker <email address hidden>
Date: Wed Jul 22 10:56:55 2015 +1200

    Catch NotFound in format_stack_resource for nested()

    If the underlying nested stack doesn't exist for whatever reason,
    calling heat resource-list results in a NotFound response even though heat
    stack-show confirms the stack exists.

    This change catches NotFound when calling resource.nested() in
    format_stack_resource.

    Change-Id: Iba92d0590561dffb8f902865cc7134b2eddc23ac
    Closes-Bug: #1476834

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steve Baker (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/204302
Reason: Replaced by https://review.openstack.org/#/c/216481/

[Steve Baker (steve-stevebaker)]

Review for kilo backport https://review.openstack.org/#/c/216481/