Some network cards ignore ipmi request to boot from disk

[Clint Byrum]

When testing ironic with some HP servers which have Mellanox network cards in them, it appears that they ignore the IPMI request to boot from disk. This means that after rebooting after deploy, the node will try to network boot again. Because the PXE driver that is in use leaves the boot files in place, this will result in a stuck node that will not boot into the image that was deployed.

Suggested remedy is to be defensive and remove any boot files so that the node will not receive PXE instructions and will fall through to disk boot.

[Julia Kreger (juliaashleykreger)]

The standard PXE driver cleans up the tftp contents when the agent driver does not do so. In the case where reported, the user is using the agent driver for deployment, and while the mellonox cards are always attempting PXE, if the tftp files are no longer present after deploy, the node gives up attempting to PXE and boots utilizing it's bios settings.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/204265

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/204265
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=a31b35c61c8e1a7c632ce5e400fc96025818e4fb
Submitter: Jenkins
Branch: master

commit a31b35c61c8e1a7c632ce5e400fc96025818e4fb
Author: Julia Kreger <email address hidden>
Date: Tue Jul 21 17:10:39 2015 -0400

    Clean up tftp files if agent deployed disk image

    After a deployment is complete, the tftp boot files that allow
    a node to boot into the agent, should be removed from the tftp
    server specificially if a whole disk image is deployed as the
    whole disk image should have sufficent infrastucture to boot
    its self.

    If this is not done and the files are left on disk, then a
    server may end up booting the agent from the network instead
    of the instance operating system from local storage if the
    firmware does not honor or support setting the boot device.

    Change-Id: Ib6caa445cd577e295c89e908650b29f5823523ed
    Closes-Bug: #1476489